Page MenuHome
Create Task
Maniphest T96213

Crash when texture painting across multiple materials
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.09

Blender Version
Broken: version: 3.1.0 Release Candidate, branch: master, commit date: 2022-03-04 14:21, hash: rB45079b169dc5
Caused by rBd743ef91df74: Fix 3d texture painting artifacts.

Short description of error
Crashes when painting inbetween two materials on the same object.

Exact steps for others to reproduce the error

texturecrash.blend856 KBDownload

Paint in-between the two materials. Painting on one only doesn't crash. Only crashes when you paint in between the two.

Each material has it's own texture that you can paint to.

Revisions and Commits

rB Blender
D14274rB1d902a6367d1 Fix T96213: Crash when texture painting across multiple materials.

Related Objects

Event Timeline

Keen Foong (kfoong) created this task.Mar 7 2022, 12:55 PM
Keen Foong (kfoong) updated the task description. (Show Details)
Keen Foong (kfoong) added a comment.Mar 7 2022, 12:58 PM

Crash file:

texturecrash.crash.txt40 KBDownload

Keen Foong (kfoong) updated the task description. (Show Details)Mar 7 2022, 1:00 PM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Mar 7 2022, 1:06 PM
Pratik Borhade (PratikPB2123) added a comment.Mar 7 2022, 1:10 PM

Broke between eb0f8317e231 - eabdcdcd44b9
Will bisect.

Pratik Borhade (PratikPB2123) triaged this task as High priority.Mar 7 2022, 1:59 PM
Pratik Borhade (PratikPB2123) edited projects, added BF Blender (3.1), EEVEE & Viewport, Sculpt, Paint & Texture; removed BF Blender.
Pratik Borhade (PratikPB2123) added subscribers: Jeroen Bakker (jbakker), Thomas Dinges (dingto).

@Jeroen Bakker (jbakker) hi, can you take a look? First bad commit appears to be rBd743ef91df74: Fix 3d texture painting artifacts.

Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Mar 7 2022, 2:01 PM
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)
Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Mar 7 2022, 2:19 PM
Jeroen Bakker (jbakker) claimed this task.Mar 7 2022, 2:57 PM
Thomas Dinges (dingto) moved this task from Backlog to bcon4: Show Stoppers on the BF Blender (3.1) board.Mar 7 2022, 3:42 PM
Jeroen Bakker (jbakker) added a comment.Mar 8 2022, 8:06 AM

@Pratik Borhade (PratikPB2123) I am not able to reproduce it on my system (Linux+AMD). Can someone add a stack trace?

Pratik Borhade (PratikPB2123) added a comment.Mar 8 2022, 8:11 AM

Can someone add a stack trace?

(Will also upload video recording)

blender.exe         :0x00007FF7222E2E10  image_gpu_texture_try_partial_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image_gpu.cc:358
blender.exe         :0x00007FF7222E2870  image_get_gpu_texture C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\image_gpu.cc:408
blender.exe         :0x00007FF7226CF4F0  workbench_image_setup_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\engines\workbench\workbench_materials.c:252
blender.exe         :0x00007FF722686B60  workbench_cache_populate C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\engines\workbench\workbench_engine.c:397
blender.exe         :0x00007FF72264DE30  drw_engines_cache_populate C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1061
blender.exe         :0x00007FF72264A650  DRW_draw_render_loop_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1664
blender.exe         :0x00007FF72264B720  DRW_draw_view C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1586
blender.exe         :0x00007FF722CA65D0  view3d_main_region_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\space_view3d\view3d_draw.c:1564
blender.exe         :0x00007FF722237980  ED_region_do_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:547
blender.exe         :0x00007FF72221F400  wm_draw_window_offscreen C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:716
blender.exe         :0x00007FF72221F250  wm_draw_window C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:868
blender.exe         :0x00007FF72221ED90  wm_draw_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:1067
blender.exe         :0x00007FF7221F9880  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:629
blender.exe         :0x00007FF7221F5060  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:549
blender.exe         :0x00007FF723146754  __scrt_common_main_seh d:\a01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FFE0DC07020  BaseThreadInitThunk
ntdll.dll           :0x00007FFE0F262630  RtlUserThreadStart
Pratik Borhade (PratikPB2123) added a comment.EditedMar 8 2022, 8:19 AM

Video recorded on build of master branch: 901a03725ed58166e5b2401dfadd7c1cb7e490a2 (same for 3.1.0)
To get the crash- Hold and drag LMB from one to other material

System Information
Operating system : Windows-10-10.0.18362-SP0 64 Bits
Graphics card : AMD Radeon(TM) 535 ATI Technologies .
Jeroen Bakker (jbakker) added a comment.Mar 8 2022, 8:21 AM

Hmm will try on windows. the line itself is a bit weird...

According to my source tree the crash happens at

BLI_rcti_size_x(&clipped_update_region),

which is just subtracting two integers on the stack...

Pratik Borhade (PratikPB2123) added a comment.Mar 8 2022, 8:27 AM

According to my source tree the crash happens at BLI_rcti_size_x(&clipped_update_region)

You probably have checked the code on 3.1 branch
On master it shows crash at image_gpu_texture_partial_update_changes_available(image, changes);

Jeroen Bakker (jbakker) added a comment.Mar 8 2022, 8:39 AM

Which is still strange. What can possible go wrong there that leads to a crash... Currently building a similar system to reproduce the issue...

Jeroen Bakker (jbakker) added a comment.Mar 8 2022, 9:30 AM

I am able to reproduce the issue on release builds on windows.

Jeroen Bakker (jbakker) added a revision: D14274: Fix T96213: Crash when texture painting across multiple materials..Mar 8 2022, 10:33 AM
Jeroen Bakker (jbakker) closed this task as Resolved by committing rB1d902a6367d1: Fix T96213: Crash when texture painting across multiple materials..Mar 8 2022, 10:38 AM
Jeroen Bakker (jbakker) added a commit: rB1d902a6367d1: Fix T96213: Crash when texture painting across multiple materials..
Jordan Miller (rolandmm) added a subscriber: Jordan Miller (rolandmm).Mar 11 2022, 1:18 AM
This comment was removed by Jordan Miller (rolandmm).
Jordan Miller (rolandmm) added a comment.Mar 11 2022, 1:30 AM
This comment was removed by Jordan Miller (rolandmm).