Debug Assert with PrintScrn & ScrollLock keys
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: GeForce GTX 745/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.11

Blender Version
Broken: version: 3.2.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: rBUnknown
Worked: (newest version of Blender that worked as expected)

Short description of error
Debug Assert aborts blender when pressing printscreen or scrolllock keys

Exact steps for others to reproduce the error

wm_event_state_update_and_click_set has a BLI_assert that the event->type is in the set of ISKEYBOARD_OR_BUTTON. But pressing PrintScrn, Alt-PrintScr, ScrollLock result in that being zero. We can't do anything with these keys, so I don't think we need to be defining them specifically. But perhaps altering that code like the following?

diff --git a/source/blender/windowmanager/intern/wm_event_system.c b/source/blender/windowmanager/intern/wm_event_system.c
index 6b7d3045da2..5af3f7d2f45 100644
--- a/source/blender/windowmanager/intern/wm_event_system.c
+++ b/source/blender/windowmanager/intern/wm_event_system.c
@@ -4864,9 +4864,9 @@ static wmEvent *wm_event_add_trackpad(wmWindow *win, const wmEvent *event, int d
 static void wm_event_state_update_and_click_set(const GHOST_TEventType type,
                                                 wmEvent *event,
                                                 wmEvent *event_state)
 {
-  BLI_assert(ISKEYBOARD_OR_BUTTON(event->type));
+  BLI_assert(ISKEYBOARD_OR_BUTTON(event->type) || !event->type);
   BLI_assert(ELEM(event->val, KM_PRESS, KM_RELEASE));
 
   /* Only copy these flags into the `event_state`. */
   const eWM_EventFlag event_state_flag_mask = WM_EVENT_IS_REPEAT;

But not sure if this fits with the intent of the author of this assert.