Page MenuHome
Create Task
Maniphest T97028

Audio scrubbing plays current frame when changing any color management setting.
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65

Blender Version
Broken: version: 3.1.0, branch: master, commit date: 2022-03-08 18:16, hash: rBc77597cd0e15
Worked: (newest version of Blender that worked as expected)

When using a piece of audio in your blender file (VSE) and you enable audio scrubbing, every time the value of the exposure (or gamma) slider changes the audio at your current frame plays.

Revisions and Commits

rB Blender
AbandonedD14547 Fix T97028: Audio plays when scene is updated

Related Objects

Event Timeline

Christopher Hosken (Cjhosken) created this task.Apr 4 2022, 1:42 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Apr 4 2022, 1:59 PM

T97003: Regression: Blender doesn't allow to animate any Colormanagement setting (e.g. Exposure) / rB35aedd87e78d: Fix T66913: undo after frame-change doesn't refresh properly are probably related

Philipp Oeser (lichtwerk) added projects: VFX & Video, Video Sequencer, Render & Cycles.Apr 4 2022, 2:43 PM
In T97028#1334800, @Philipp Oeser (lichtwerk) wrote:

T97003: Regression: Blender doesn't allow to animate any Colormanagement setting (e.g. Exposure) / rB35aedd87e78d: Fix T66913: undo after frame-change doesn't refresh properly are probably related

Nope, this was also the case before rB35aedd87e78d.
Updating colormanagement settings just happens to notify the sequencer, which in turn seeks the audio.
Would still think this is somewhat a bug.

Philipp Oeser (lichtwerk) renamed this task from Audio scrubbing plays current frame when changing color management exposure. to Audio scrubbing plays current frame when changing any color management setting..Apr 4 2022, 2:43 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Apr 4 2022, 2:55 PM
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).Apr 4 2022, 3:28 PM

Don't think this is because sequencer is notified. This happens with other properties as well like use_simplify or use_freestyle which do not update sequencer. These do tag scene dependency graph for update. Scene is also tagged in rna_ColorManagement_update. WM_main_add_notifier should cause only redraw.

I guess this could be fixed if sound scrubbing would be handled by scrubbing operator. I can try to do that.

Philipp Oeser (lichtwerk) added a comment.Apr 4 2022, 3:35 PM
In T97028#1334925, @Richard Antalik (ISS) wrote:

Don't think this is because sequencer is notified. This happens with other properties as well like use_simplify or use_freestyle which do not update sequencer. These do tag scene dependency graph for update. Scene is also tagged in rna_ColorManagement_update. WM_main_add_notifier should cause only redraw.

I guess this could be fixed if sound scrubbing would be handled by scrubbing operator. I can try to do that.

Ah, OK, so it is the (too general) tagging of scene via DEG_id_tag_update(id, 0)

Philipp Oeser (lichtwerk) mentioned this in T97003: Regression: Blender doesn't allow to animate any Colormanagement setting (e.g. Exposure).Apr 4 2022, 3:40 PM
Philipp Oeser (lichtwerk) added a subscriber: Sergey Sharybin (sergey).

@Sergey Sharybin (sergey) suggested P2882 in related T97003, seems to fix the issue here, too

Richard Antalik (ISS) added a revision: D14547: Fix T97028: Audio plays when scene is updated.Apr 4 2022, 4:56 PM
Richard Antalik (ISS) added a comment.Apr 4 2022, 4:57 PM

That sounds reasonable as fix. My thought was to untangle sound code just a tiny bit. and maybe learn something in the process. Since have I started already, I will submit fix too.

Philipp Oeser (lichtwerk) closed this task as Resolved.Apr 5 2022, 4:09 PM
Philipp Oeser (lichtwerk) claimed this task.

This is also resolved by rB328dfab4236a: Fix T97003: color-management settings can't be animated