Page MenuHome
Create Task
Maniphest T98603

Regression: Hang when saving project in material preview mode
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-11 Pro,Amd Ryzen 7 3700x,32GB RAM,(Asus TUF Plus Gaming)
Graphics card: NVIDIA GeForce GTX 1070 8GB

Blender Version
Broken: 3.2, 3.3
Working: 3.1
Caused by rB9c82c00b3280: GPUMaterial: Rework the deferred compilation to not use double locks

Short description of error
Freeze when saving project in material preview mode

Exact steps for others to reproduce the error

  • Open provided .blend file
  • switch to edit mode and viewport shading to material preview
  • make any change in scene
  • Save the file (freeze)

Blender 3.2.0 RC - is hanging,when saving project in secondary material preview viewport (2022) bug .blend10 MBDownload

Revisions and Commits

rB Blender
D15135rB58d350b4892d GPUMaterial: Make compilation fail when reusing failed `GPUPass`

Related Objects

Event Timeline

Szymon Warunek (szymi) created this task.Jun 5 2022, 3:09 AM

[Blender 3.2.0 RC - is hanging,when saving project in secondary material preview viewport (2022) bug]

Szymon Warunek (szymi) updated the task description. (Show Details)Jun 5 2022, 3:14 AM
Szymon Warunek (szymi) updated the task description. (Show Details)
Szymon Warunek (szymi) updated the task description. (Show Details)
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)Jun 6 2022, 7:36 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Jun 6 2022, 7:53 AM

Thanks for the report. I can confirm. This looks like a regression.
Will start bisecting.
Could you help in simplifying the file? (I'll also to this)

Pratik Borhade (PratikPB2123) renamed this task from Blender 3.2.0 RC - is hanging,when saving project in secondary material viewport shading (2022) bug to Regression: Hang when saving project in material preview mode.Jun 6 2022, 7:57 AM
Pratik Borhade (PratikPB2123) added a project: EEVEE & Viewport.
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)
Pratik Borhade (PratikPB2123) triaged this task as High priority.Jun 6 2022, 12:09 PM
Pratik Borhade (PratikPB2123) added a subscriber: Clément Foucault (fclem).

Affected by this commit rB9c82c00b3280: GPUMaterial: Rework the deferred compilation to not use double locks
@Clément Foucault (fclem), could you check?

Pratik Borhade (PratikPB2123) updated the task description. (Show Details)Jun 6 2022, 12:11 PM
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)
Pratik Borhade (PratikPB2123) added a subscriber: Thomas Dinges (dingto).

@Thomas Dinges (dingto) hi, do you consider this a showstopper?

Clément Foucault (fclem) claimed this task.Jun 6 2022, 4:28 PM

So this happens only because some materials are invalid and their GPUPass is reused. The first material to be compiled fail but the subsequent ones are kept in a GPU_MAT_QUEUED state. Making them fail early fixes the issue but I am not sure if that doesn't hide an issue with the deferred compilation.

This is a simpler file to reproduce the issue:

T98603.blend852 KBDownload

I can reproduce the material being kept in queued state in 3.1 so the only change is that it is now blocking the file saving.

Clément Foucault (fclem) added a revision: D15135: GPUMaterial: Make compilation fail when reusing failed `GPUPass`.Jun 6 2022, 4:59 PM
Clément Foucault (fclem) closed this task as Resolved by committing rB58d350b4892d: GPUMaterial: Make compilation fail when reusing failed `GPUPass`.Jun 7 2022, 10:49 AM
Clément Foucault (fclem) added a commit: rB58d350b4892d: GPUMaterial: Make compilation fail when reusing failed `GPUPass`.