Page MenuHome
Create Task
Maniphest T99791

Regression: "Store Named Attribute" node affects all vertex groups after than the one specified.
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Arch Linux w/ Linux-5.18.10-zen1-1-zen-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.57

Blender Version
Broken: version: 3.3.0
Worked: 3.2.1
Caused by rB12bde317f4c9: Fix T98949: Deleting vertex group in geometry nodes affects others

Short description of error
Seems to be related to T99787
Modifying a vertex group with the "Store Named Attribute" node affects all groups after that one.

Exact steps for others to reproduce the error

  1. Add many one vertex groups to a mesh.
  2. Assign some weight to the vertex groups to make the issue more clear.
  3. Add a "Store Named Attribute" node to a geometry nodes group on the object.
  4. Set the target attribute to a vertex group near the top of list in the properties panel.
  5. Note that the vertex group's weights of groups after the targeted group have been shifted up on in the list.

NoArmature.blend104 KBDownload

Related Objects

Event Timeline

Chris D (CheesecakeCG) created this task.Jul 17 2022, 10:12 AM
Chris D (CheesecakeCG) mentioned this in T99787: "Store Named Attribute" node affects vertex group after the one specified..
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.Jul 18 2022, 2:38 AM
Pratik Borhade (PratikPB2123) added projects: Geometry Nodes, Nodes & Physics.
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).

Thanks for the report. I can confirm this. Will do the bisect

Pratik Borhade (PratikPB2123) triaged this task as High priority.Jul 18 2022, 7:26 AM
Pratik Borhade (PratikPB2123) added a subscriber: Hans Goudey (HooglyBoogly).

Broken since rB12bde317f4c9: Fix T98949: Deleting vertex group in geometry nodes affects others
cc @Hans Goudey (HooglyBoogly)

Pratik Borhade (PratikPB2123) renamed this task from "Store Named Attribute" node affects all vertex groups after than the one specified. to Regression: "Store Named Attribute" node affects all vertex groups after than the one specified. .Jul 18 2022, 7:27 AM
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)
Pratik Borhade (PratikPB2123) updated the task description. (Show Details)Jul 18 2022, 1:26 PM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).Jul 23 2022, 1:43 PM

Can you check if that is fixed? Think it was fixed by rBc40971d79a887820d621705b29f65f833d9b9f52 + rB5da807e00fb75de31442f872f4997ba361be00f8.

It seems like it might not have been a bug in geometry nodes before, but I'm not sure. The spreadsheet already showed the correct values, just the viewport was drawing the wrong data it seems.

Jacques Lucke (JacquesLucke) merged a task: T99787: "Store Named Attribute" node affects vertex group after the one specified..Jul 23 2022, 2:02 PM
Pratik Borhade (PratikPB2123) added a comment.Jul 23 2022, 3:37 PM

Works fine in current master (d53ea1d0af58cfdcd230e75ba4ac58453bdbd808)
We can now close this report :)

Jacques Lucke (JacquesLucke) closed this task as Resolved.Jul 23 2022, 3:39 PM
Jacques Lucke (JacquesLucke) claimed this task.
Alexander Gavrilov (angavrilov) added a subscriber: Alexander Gavrilov (angavrilov).EditedJul 25 2022, 1:42 PM
In T99791#1394416, @Jacques Lucke (JacquesLucke) wrote:

It seems like it might not have been a bug in geometry nodes before, but I'm not sure.

The 'affects all group after' part is a manifestation of a 'name list vs data' mismatch bug, which is a consequence of code incompletely updated to account for the possibility of the vertex group list being changed by modifiers, which wasn't possible before. For instance, rB80b2fc59d11d5814afe7 fixes the Armature modifier; however there are very likely other cases of this.

The Store Named Attribute node also had a bug where it always deleted the existing attribute and created it from scratch, instead of writing to the existing one. This part was fixed by the commits you mentioned above, however the mismatch bug may still be triggerable via the Remove node.

The rB12bde317f4c9 commit does not cause any bug, it merely revealed hidden bugs in other code by fixing a bug.