Differential D2451 Diff 8780 source/blender/imbuf/intern/thumbs_blend.c

Changeset View

Standalone View

source/blender/imbuf/intern/thumbs_blend.c

	Show All 26 Lines

	#include <stdlib.h>			#include <stdlib.h>
	#include <string.h>			#include <string.h>

	#include "BLI_utildefines.h"			#include "BLI_utildefines.h"
	#include "BLI_endian_switch.h"			#include "BLI_endian_switch.h"
	#include "BLI_fileops.h"			#include "BLI_fileops.h"
	#include "BLI_linklist.h"			#include "BLI_linklist.h"
				#include "BLI_listbase.h"
				mont29Unsubmitted Not Done Inline Actions Why is this needed???? Or is it a left-over from some merge? mont29: Why is this needed???? Or is it a left-over from some merge?
				SeverinAuthorUnsubmitted Not Done Inline Actions Getting a compile error without it, but it's in `BLO_readfile` so can easily avoid adding this here. Severin: Getting a compile error without it, but it's in `BLO_readfile` so can easily avoid adding this…
				SeverinAuthorUnsubmitted Not Done Inline Actions Turns out that even though this can be avoided, it's probably preferable like I did it. This file includes `BLO_readfile.h` which now contains `ListBase workspaces` as struct member. Doing `struct ListBase` there won't work because size is unknown on compile time. So the options are including `BLI_listbase.h` in `BLO_readfile.h` or doing what I've done here (which is what I prefer). Severin: Turns out that even though this can be avoided, it's probably preferable like I did it. This…
				mont29Unsubmitted Not Done Inline Actions Cleaned up a bit, but indeed looks like we have no choice but to link listbase here… no big deal anyway. mont29: Cleaned up a bit, but indeed looks like we have no choice but to link listbase here… no big…

	#include "BLO_blend_defs.h"			#include "BLO_blend_defs.h"
	#include "BLO_readfile.h"			#include "BLO_readfile.h"

	#include "BKE_global.h"			#include "BKE_global.h"
	#include "BKE_idcode.h"			#include "BKE_idcode.h"
	#include "BKE_icons.h"			#include "BKE_icons.h"
	#include "BKE_library.h"			#include "BKE_library.h"
	▲ Show 20 Lines • Show All 134 Lines • Show Last 20 Lines