Changeset View
Changeset View
Standalone View
Standalone View
source/blender/makesrna/intern/rna_scene.c
| Context not available. | |||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_BOOL(motion_blur_enable) | RNA_LAYER_ENGINE_EEVEE_GET_SET_BOOL(motion_blur_enable) | ||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_INT(motion_blur_samples) | RNA_LAYER_ENGINE_EEVEE_GET_SET_INT(motion_blur_samples) | ||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_FLOAT(motion_blur_shutter) | RNA_LAYER_ENGINE_EEVEE_GET_SET_FLOAT(motion_blur_shutter) | ||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_BOOL(fxaa_enable) | |||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_INT(fxaa_shader_option); | |||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_FLOAT(fxaa_subpix) | |||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_FLOAT(fxaa_edge_threshold) | |||||
| RNA_LAYER_ENGINE_EEVEE_GET_SET_FLOAT(fxaa_edge_threshold_min) | |||||
| /* object engine */ | /* object engine */ | ||||
| RNA_LAYER_MODE_OBJECT_GET_SET_BOOL(show_wire) | RNA_LAYER_MODE_OBJECT_GET_SET_BOOL(show_wire) | ||||
| Context not available. | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | ||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | ||||
| prop = RNA_def_property(srna, "fxaa_enable", PROP_BOOLEAN, PROP_NONE); | |||||
| RNA_def_property_boolean_funcs(prop, "rna_LayerEngineSettings_Eevee_fxaa_enable_get", | |||||
| "rna_LayerEngineSettings_Eevee_fxaa_enable_set"); | |||||
| RNA_def_property_ui_text(prop, "FXAA", "Enable FXAA antialiasing"); | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | |||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | |||||
| prop = RNA_def_property(srna, "fxaa_shader_option", PROP_INT, PROP_UNSIGNED); | |||||
| RNA_def_property_int_funcs(prop, "rna_LayerEngineSettings_Eevee_fxaa_shader_option_get", | |||||
| "rna_LayerEngineSettings_Eevee_fxaa_shader_option_set", NULL); | |||||
| RNA_def_property_ui_text(prop, "Debug", "Debug FXAA"); | |||||
| RNA_def_property_ui_range(prop, 0, 2, 1, 1); | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | |||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | |||||
| prop = RNA_def_property(srna, "fxaa_subpix", PROP_FLOAT, PROP_UNSIGNED); | |||||
| RNA_def_property_float_funcs(prop, "rna_LayerEngineSettings_Eevee_fxaa_subpix_get", | |||||
| "rna_LayerEngineSettings_Eevee_fxaa_subpix_set", NULL); | |||||
| RNA_def_property_ui_text(prop, "Subpix", "Amount of subpixel aliasing removal"); | |||||
| RNA_def_property_ui_range(prop, 0.00f, 1.0f, 0.25, 3); | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | |||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | |||||
| prop = RNA_def_property(srna, "fxaa_edge_threshold", PROP_FLOAT, PROP_UNSIGNED); | |||||
| RNA_def_property_float_funcs(prop, "rna_LayerEngineSettings_Eevee_fxaa_edge_threshold_get", | |||||
| "rna_LayerEngineSettings_Eevee_fxaa_edge_threshold_set", NULL); | |||||
| RNA_def_property_ui_text(prop, "Edge threshold", "Minimum amount of local contrast required to apply antialiasing"); | |||||
| RNA_def_property_ui_range(prop, 0.063f, 0.333f, 0.0211, 4); | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | |||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | |||||
| prop = RNA_def_property(srna, "fxaa_edge_threshold_min", PROP_FLOAT, PROP_UNSIGNED); | |||||
| RNA_def_property_float_funcs(prop, "rna_LayerEngineSettings_Eevee_fxaa_edge_threshold_min_get", | |||||
| "rna_LayerEngineSettings_Eevee_fxaa_edge_threshold_min_set", NULL); | |||||
| RNA_def_property_ui_text(prop, "Edge threshold min", "Trims antialiasing from processing very dark regions"); | |||||
dfelinto: UI text should follow the following rule:
* First letters are always capitalized.
* No… | |||||
cmrAuthorUnsubmitted Done Inline ActionsI'm thinking of removing these tuning parameters too. By my measurements they don't (meaningfully) impact performance on modernish cards, and are somewhat hard to understand the exact effects of for anyone who isn't familiar with the shader (or has the debug option ;)). What do you think? cmr: I'm thinking of removing these tuning parameters too. By my measurements they don't… | |||||
dfelintoUnsubmitted Done Inline ActionsI think this is a great idea. If performance is really an issue the user can simply run without anti-alias altogether. dfelinto: I think this is a great idea. If performance is really an issue the user can simply run without… | |||||
| RNA_def_property_ui_range(prop, 0.0312f, 0.0833f, 0.005, 5); | |||||
| RNA_def_property_flag(prop, PROP_CONTEXT_UPDATE); | |||||
| RNA_def_property_update(prop, NC_SCENE | ND_LAYER_CONTENT, "rna_SceneLayerEngineSettings_update"); | |||||
| RNA_define_verify_sdna(1); /* not in sdna */ | RNA_define_verify_sdna(1); /* not in sdna */ | ||||
| } | } | ||||
| Context not available. | |||||
UI text should follow the following rule:
So my suggestions would be:
And remove the debug option indeed.