Differential D2951 Diff 9670 source/blender/alembic/intern/alembic_capi.cc

Changeset View

Standalone View

source/blender/alembic/intern/alembic_capi.cc

Context not available.
	void *abc_path_void = MEM_callocN(sizeof(AlembicObjectPath), "AlembicObjectPath");	void *abc_path_void = MEM_callocN(sizeof(AlembicObjectPath), "AlembicObjectPath");
	AlembicObjectPath abc_path = static_cast<AlembicObjectPath >(abc_path_void);	AlembicObjectPath abc_path = static_cast<AlembicObjectPath >(abc_path_void);

		abc_path->path = (*char) malloc(sizeof(object.getFullName().c_str()));
		LazyDodoUnsubmitted Not Done Inline Actions this will allocate the size of a pointer, also it's preferred to use the guarded memory allocator (MEM_* functions) like the rest of the file does. LazyDodo: this will allocate the size of a pointer, also it's preferred to use the guarded memory…
		kevindietrichUnsubmitted Not Done Inline Actions Should something like: abc_path->path = static_cast<char >(MEM_mallocN(sizeof(char) full_name.size()), "Alembic object path str"); Also, I prefer to be consistent with the code style, and keep using C++ style casting. kevindietrich: Should something like: abc_path->path = static_cast<char >(MEM_mallocN(sizeof(char) …
	BLI_strncpy(abc_path->path, object.getFullName().c_str(), sizeof(abc_path->path));	BLI_strncpy(abc_path->path, object.getFullName().c_str(), sizeof(abc_path->path));
		LazyDodoUnsubmitted Not Done Inline Actions since since abc_path->path is now a pointer as well, this will copy at most 4/8 bytes and lack a zero teminator. LazyDodo: since since abc_path->path is now a pointer as well, this will copy at most 4/8 bytes and lack…
		kevindietrichUnsubmitted Not Done Inline Actions Should something like: BLI_strncpy(abc_path->path, full_name.c_str(), full_name.size()); kevindietrich: Should something like: BLI_strncpy(abc_path->path, full_name.c_str(), full_name.size());
	BLI_addtail(object_paths, abc_path);	BLI_addtail(object_paths, abc_path);
	}	}
		kevindietrichUnsubmitted Not Done Inline Actions This will free the path directly and destroy its content, but we need it for the UI. Freeing of the strings should be done in `cachefile.c` before the line `BLI_freelistN(&cache_file->object_paths);`. kevindietrich: This will free the path directly and destroy its content, but we need it for the UI. Freeing of…
Context not available.

	AlembicObjectPath abc_path = static_cast<AlembicObjectPath >(	AlembicObjectPath abc_path = static_cast<AlembicObjectPath >(
	MEM_callocN(sizeof(AlembicObjectPath), "AlembicObjectPath"));	MEM_callocN(sizeof(AlembicObjectPath), "AlembicObjectPath"));
		abc_path->path = (*char) malloc(sizeof(full_name.c_str()));
		LazyDodoUnsubmitted Not Done Inline Actions same. LazyDodo: same.
	BLI_strncpy(abc_path->path, full_name.c_str(), sizeof(abc_path->path));	BLI_strncpy(abc_path->path, full_name.c_str(), sizeof(abc_path->path));
	BLI_addtail(&settings.cache_file->object_paths, abc_path);	BLI_addtail(&settings.cache_file->object_paths, abc_path);

Context not available.
		kevindietrichUnsubmitted Not Done Inline Actions Here as well, we shouldn't free directly. kevindietrich: Here as well, we shouldn't free directly.
		kevindietrichUnsubmitted Not Done Inline Actions Should be something like: abc_path->path = static_cast<char >(MEM_mallocN(sizeof(char) full_name.size()), "Alembic object path str"); BLI_strncpy(abc_path->path, full_name.c_str(), full_name.size()); kevindietrich: Should be something like: abc_path->path = static_cast<char >(MEM_mallocN(sizeof(char) …