Page MenuHome
Differential D2924 Diff 9679 source/blender/editors/space_sequencer/sequencer_add.c

Changeset View

Standalone View

View Options

source/blender/editors/space_sequencer/sequencer_add.c

Show First 20 Lines • Show All 305 Lines • ▼ Show 20 Linesstatic int sequencer_add_scene_strip_exec(bContext *C, wmOperator *op)
seq->blend_mode = SEQ_TYPE_CROSS; /* so alpha adjustment fade to the strip below */ seq->blend_mode = SEQ_TYPE_CROSS; /* so alpha adjustment fade to the strip below */
seq->scene = sce_seq; seq->scene = sce_seq;
/* basic defaults */ /* basic defaults */
seq->strip = strip = MEM_callocN(sizeof(Strip), "strip"); seq->strip = strip = MEM_callocN(sizeof(Strip), "strip");
seq->len = sce_seq->r.efra - sce_seq->r.sfra + 1; seq->len = sce_seq->r.efra - sce_seq->r.sfra + 1;
strip->us = 1; strip->us = 1;
BLI_strncpy(seq->view_render.engine_id, scene->view_render.engine_id, 32); /* default is current scene's view_render settings */
campbellbartonUnsubmitted
Not Done
Inline Actions

This is not default, this is just copying, if scene changes engine, the sequencer wont follow.

campbellbarton: This is not default, this is just copying, if scene changes engine, the sequencer wont follow.
spockTheGrayAuthorUnsubmitted
Not Done
Inline Actions

Ah, sorry I misunderstood. thought "default" meant just at strip initialization - didn't know strip settings needed to stay (optionally) synced w/ scene render settings thereafter too. I'll fix this

spockTheGray: Ah, sorry I misunderstood. thought "default" meant just at strip initialization - didn't know…
campbellbartonUnsubmitted
Done
Inline Actions

The intention is - by default this can follow the scene, ability to change the engine is an optional override.

This avoids a situation where you might need to mess with 100's of strips engine setting because there is no good way to simply use whatever the scene has set.

campbellbarton: The intention is - by default this can follow the scene, ability to change the engine is an…
campbellbartonUnsubmitted
Done
Inline Actions

Again, why is this being done? the engine used when adding a strip shouldn't matter.

campbellbarton: Again, why is this being done? the engine used when adding a strip shouldn't matter.
BLI_strncpy(seq->name + 2, sce_seq->id.name + 2, sizeof(seq->name) - 2); BLI_strncpy(seq->name + 2, sce_seq->id.name + 2, sizeof(seq->name) - 2);
BKE_sequence_base_unique_name_recursive(&ed->seqbase, seq); BKE_sequence_base_unique_name_recursive(&ed->seqbase, seq);
seq->scene_sound = BKE_sound_scene_add_scene_sound(scene, seq, start_frame, start_frame + seq->len, 0); seq->scene_sound = BKE_sound_scene_add_scene_sound(scene, seq, start_frame, start_frame + seq->len, 0);
BKE_sequence_calc_disp(scene, seq); BKE_sequence_calc_disp(scene, seq);
BKE_sequencer_sort(scene); BKE_sequencer_sort(scene);
▲ Show 20 Lines • Show All 794 Lines • Show Last 20 Lines