Page MenuHome
Differential D3966 Diff 12572 source/blender/bmesh/tools/bmesh_bisect_plane.c

Changeset View

Standalone View

View Options

source/blender/bmesh/tools/bmesh_bisect_plane.c

Context not available.
/* common case, just cut the face once */ /* common case, just cut the face once */
BM_face_split(bm, f, l_a, l_b, &l_new, NULL, true); BM_face_split(bm, f, l_a, l_b, &l_new, NULL, true);
if (l_new) { if (l_new && bm->use_toolflags) {
campbellbartonUnsubmitted
Not Done
Inline Actions

Checks for bm->use_toolflags shouldn't be needed. Just pass in zero oflag_center .. etc.

campbellbarton: Checks for `bm->use_toolflags` shouldn't be needed. Just pass in zero `oflag_center` .. etc.
if (oflag_center | oflag_new) { if (oflag_center | oflag_new) {
BMO_edge_flag_enable(bm, l_new->e, oflag_center | oflag_new); BMO_edge_flag_enable(bm, l_new->e, oflag_center | oflag_new);
} }
Context not available.
BMFace *f_tmp; BMFace *f_tmp;
f_tmp = BM_face_split(bm, face_split_arr[j], l_a, l_b, &l_new, NULL, true); f_tmp = BM_face_split(bm, face_split_arr[j], l_a, l_b, &l_new, NULL, true);
if (l_new) { if (l_new && bm->use_toolflags) {
if (oflag_center | oflag_new) { if (oflag_center | oflag_new) {
BMO_edge_flag_enable(bm, l_new->e, oflag_center | oflag_new); BMO_edge_flag_enable(bm, l_new->e, oflag_center | oflag_new);
} }
Context not available.
BM_VERT_DIR(v) = plane_point_test_v3(plane, v->co, eps, &(BM_VERT_DIST(v))); BM_VERT_DIR(v) = plane_point_test_v3(plane, v->co, eps, &(BM_VERT_DIST(v)));
if (BM_VERT_DIR(v) == 0) { if (BM_VERT_DIR(v) == 0) {
if (oflag_center) { if (oflag_center && bm->use_toolflags) {
BMO_vert_flag_enable(bm, v, oflag_center); BMO_vert_flag_enable(bm, v, oflag_center);
} }
if (use_snap_center) { if (use_snap_center) {
Context not available.
{ {
BMEdge *e_new; BMEdge *e_new;
v_new = BM_edge_split(bm, e, e->v1, &e_new, e_fac); v_new = BM_edge_split(bm, e, e->v1, &e_new, e_fac);
if (oflag_new) { if (oflag_new && bm->use_toolflags) {
BMO_edge_flag_enable(bm, e_new, oflag_new); BMO_edge_flag_enable(bm, e_new, oflag_new);
} }
} }
vert_is_center_enable(v_new); vert_is_center_enable(v_new);
if (oflag_new | oflag_center) { if ((oflag_new | oflag_center) && bm->use_toolflags) {
BMO_vert_flag_enable(bm, v_new, oflag_new | oflag_center); BMO_vert_flag_enable(bm, v_new, oflag_new | oflag_center);
} }
Context not available.
} }
/* if both verts are on the center - tag it */ /* if both verts are on the center - tag it */
if (oflag_center) { if (oflag_center && bm->use_toolflags) {
if (side[0] == 0 && side[1] == 0) { if (side[0] == 0 && side[1] == 0) {
BMO_edge_flag_enable(bm, e, oflag_center); BMO_edge_flag_enable(bm, e, oflag_center);
} }
Context not available.