Differential D4062 Diff 12861 source/blender/blenlib/intern/task.c

Changeset View

Standalone View

Context not available.
	TaskScheduler *scheduler = thread->scheduler;	TaskScheduler *scheduler = thread->scheduler;
	int thread_id = thread->id;	int thread_id = thread->id;
	Task *task;	Task *task;

		velocityAuthorUnsubmitted Done Inline Actions this is fixed locally velocity: this is fixed locally
	pthread_setspecific(scheduler->tls_id_key, thread);	pthread_setspecific(scheduler->tls_id_key, thread);

	/* keep popping off tasks */	/* keep popping off tasks */
Context not available.
		sergeyUnsubmitted Done Inline Actions I'm not sure this is a great idea to change thread name in a very hot function. Surely, is not such of a problem for release builds, but we do debug complex production scenes in a debug mode. Also, this doesn't bring a lot of new information and is not complete information. Thread which does `wait_and_work` is not renamed and there you can not reliably have this wait/run semantic working without having some sort of TLS stack of all names. Don't even think it worth it. sergey: I'm not sure this is a great idea to change thread name in a very hot function. Surely, is not…
		velocityAuthorUnsubmitted Done Inline Actions Yeah that makes sense, I'll remove it. velocity: Yeah that makes sense, I'll remove it.