Page MenuHome
Differential D390 Diff 1223 source/blender/blenkernel/BKE_DerivedMesh.h

Changeset View

Standalone View

View Options

source/blender/blenkernel/BKE_DerivedMesh.h

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Linesstruct DerivedMesh {
/** Draw mapped edges as lines with interpolation values /** Draw mapped edges as lines with interpolation values
* - Only if !setDrawOptions or * - Only if !setDrawOptions or
* setDrawOptions(userData, mapped-edge, mapped-v0, mapped-v1, t) * setDrawOptions(userData, mapped-edge, mapped-v0, mapped-v1, t)
* returns true * returns true
* *
* NOTE: This routine is optional! * NOTE: This routine is optional!
*/ */
void (*drawMappedEdgesInterp)(DerivedMesh *dm, void (*drawMappedEdgesInterp)(struct Object *ob,
aligorithUnsubmitted
Not Done
Inline Actions

I'm not sure that it's good idea (or even necessary) to be passing in an object pointer here. Some reasons:

  1. All the methods here are in an OO-style, with the first parameter being DerivedMesh (i.e. equivalent to "self" in Python)
  2. The only thing you actually do with that pointer is access ob->data, and from there check if a particular flag is set.

Some better options are:

  1. Pass this value in as an additional bool argument instead (like you're doing with dt). Even better may be leaving this as a general flag, but then that may be overkill for now.
  2. Include dt and this bool argument within the "userData" struct that gets passed in, and just add some data unpacking at the start of the method.
aligorith: I'm not sure that it's good idea (or even necessary) to be passing in an object pointer here.
campbellbartonUnsubmitted
Not Done
Inline Actions

Agree, however I dont think its even needed - BMEditMesh has an object pointer.

campbellbarton: Agree, however I dont think its even needed - `BMEditMesh` has an object pointer.
DerivedMesh *dm,
DMSetDrawOptions setDrawOptions, DMSetDrawOptions setDrawOptions,
DMSetDrawInterpOptions setDrawInterpOptions, DMSetDrawInterpOptions setDrawInterpOptions,
void *userData); void *userData,
const char dt);
/** Draw all faces with materials /** Draw all faces with materials
* - setMaterial is called for every different material nr * - setMaterial is called for every different material nr
* - setFace is called to verify if a face must be hidden * - setFace is called to verify if a face must be hidden
*/ */
void (*drawMappedFacesMat)(DerivedMesh *dm, void (*drawMappedFacesMat)(DerivedMesh *dm,
void (*setMaterial)(void *userData, int, void *attribs), void (*setMaterial)(void *userData, int, void *attribs),
bool (*setFace)(void *userData, int index), void *userData); bool (*setFace)(void *userData, int index), void *userData);
▲ Show 20 Lines • Show All 300 Lines • Show Last 20 Lines