Differential D4455 Diff 14277 source/blender/editors/transform/transform_generics.c

Changeset View

Standalone View

source/blender/editors/transform/transform_generics.c

Show First 20 Lines • Show All 2,417 Lines • ▼ Show 20 Lines	else {
}		}

mat3_to_compatible_eulO(eul, td->ext->rot, td->ext->rotOrder, fmat);		mat3_to_compatible_eulO(eul, td->ext->rot, td->ext->rotOrder, fmat);

/* apply */		/* apply */
copy_v3_v3(td->ext->rot, eul);		copy_v3_v3(td->ext->rot, eul);
}		}
}		}

		/**
		* Ideally we would use #OPTYPE_USE_EVAL_DATA however
		* this is only needed in rare cases (crazy-space).
		sergeyUnsubmitted Not Done Inline Actions Only used "for now". Might be more cases in the future, leading to very fragile chain of exceptions here. Is also seems weird why crazy-space needs this, but not the snapping (which does ray-cast against evaluated meshes). sergey: Only used "for now". Might be more cases in the future, leading to very fragile chain of…
		campbellbartonAuthorUnsubmitted Done Inline Actions Snapping doesn't need this because it's modal and the evaluated data is generated for the view-port, redo isn't. campbellbarton: Snapping doesn't need this because it's modal and the evaluated data is generated for the view…
		*/
		void transform_depsgraph_eval_ensure(TransInfo *t)
		{
		if ((t->flag & T_DEPSGRAPH_EVAL) == 0) {
		sergeyUnsubmitted Not Done Inline Actions I am not sure why do you need `T_DEPSGRAPH_EVAL`. Dependency graph evaluation has an early output if nothing is tagged for an update. sergey: I am not sure why do you need `T_DEPSGRAPH_EVAL`. Dependency graph evaluation has an early…
		t->flag \|= T_DEPSGRAPH_EVAL;
		struct Main *bmain = CTX_data_main(t->context);
		BKE_scene_view_layer_graph_evaluated_ensure(bmain, t->scene, t->view_layer);
		sergeyUnsubmitted Not Done Inline Actions Not really related to this specific change, but i think `BKE_scene_view_layer_graph_evaluated_ensure()` itself needs to be changed. It is using `BKE_scene_graph_update_tagged()`, which does a lot extra things, like running callbacks. Not sure we really want those? sergey: Not really related to this specific change, but i think…
		}
		}