Differential D4911 Diff 15559 source/blender/depsgraph/intern/builder/deg_builder_map.h

Changeset View

Standalone View

source/blender/depsgraph/intern/builder/deg_builder_map.h

	Show All 27 Lines
	struct GSet;			struct GSet;
	struct ID;			struct ID;

	namespace DEG {			namespace DEG {

	class BuilderMap {			class BuilderMap {
	public:			public:
	enum {			enum {
	TAG_ANIMATION = (1 << 0),			TAG_ANIMATION = (1 << 0),
				brechtUnsubmitted Not Done Inline Actions Could we use another word than "Tag"? It already has a different meaning, or at least the link to existing tagging is not clear to me. Maybe just "USE_ANIMATION" or "BUILD_ANIMATION". brecht: Could we use another word than "Tag"? It already has a different meaning, or at least the link…
				sergeyAuthorUnsubmitted Not Done Inline Actions `USE` or `BUILD` is misleading. You are not building here and not using anything here. Can just strip the prefix, you always access to it via `BuilderMap` anyway. But i can't think of another name for the internal variables. But also not sure why there is such an urge to avoid it? There are other types of tagging in a lot of other areas (library/id, bmesh, ...) and didn't seem to be causing issues? It's just what it is. sergey: `USE` or `BUILD` is misleading. You are not building here and not using anything here. Can…
	TAG_PARAMETERS = (1 << 1),			TAG_PARAMETERS = (1 << 1),
	TAG_TRANSFORM = (1 << 2),			TAG_TRANSFORM = (1 << 2),
	TAG_GEOMETRY = (1 << 3),			TAG_GEOMETRY = (1 << 3),

				TAG_SCENE_COMPOSITOR = (1 << 4),
				TAG_SCENE_SEQUENCER = (1 << 5),

	/* All ID components has been built. */			/* All ID components has been built. */
	TAG_COMPLETE = (TAG_ANIMATION \| TAG_PARAMETERS \| TAG_TRANSFORM \| TAG_GEOMETRY),			TAG_COMPLETE = (TAG_ANIMATION \| TAG_PARAMETERS \| TAG_TRANSFORM \| TAG_GEOMETRY \|
				TAG_SCENE_COMPOSITOR \| TAG_SCENE_SEQUENCER),
	};			};

	BuilderMap();			BuilderMap();
	~BuilderMap();			~BuilderMap();

	/* Check whether given ID is already handled by builder (or if it's being handled). */			/* Check whether given ID is already handled by builder (or if it's being handled). */
	bool checkIsBuilt(ID *id, int tag = TAG_COMPLETE) const;			bool checkIsBuilt(ID *id, int tag = TAG_COMPLETE) const;

	Show All 28 Lines