Changeset View
Standalone View
source/blender/makesrna/intern/rna_space.c
| Context not available. | |||||
| #endif | #endif | ||||
| const EnumPropertyItem rna_enum_shading_type_items[] = { | const EnumPropertyItem rna_enum_shading_type_items[] = { | ||||
| {OB_WIRE, "WIREFRAME", ICON_SHADING_WIRE, "Wireframe", "Display the object as wire edges"}, | {OB_WIRE, "WIREFRAME", ICON_SHADING_WIRE, "Wireframe", "Display scene as wire edges"}, | ||||
| {OB_SOLID, "SOLID", ICON_SHADING_SOLID, "Solid", "Display in solid mode"}, | {OB_SOLID, "SOLID", ICON_SHADING_SOLID, "Solid", "Display scene as plain solid surfaces"}, | ||||
| {OB_MATERIAL, "MATERIAL", ICON_SHADING_TEXTURE, "Look Dev", "Display in Look Dev mode"}, | {OB_MATERIAL, "MATERIAL", ICON_SHADING_TEXTURE, "Look Dev", "Display scene as real-time render approximation"}, | ||||
| {OB_RENDER, "RENDERED", ICON_SHADING_RENDERED, "Rendered", "Display render preview"}, | {OB_RENDER, "RENDERED", ICON_SHADING_RENDERED, "Rendered", "Display scene as render preview"}, | ||||
| {0, NULL, 0, NULL, NULL}, | {0, NULL, 0, NULL, NULL}, | ||||
| }; | }; | ||||
| Context not available. | |||||
| "rna_3DViewShading_type_set", | "rna_3DViewShading_type_set", | ||||
| "rna_3DViewShading_type_itemf"); | "rna_3DViewShading_type_itemf"); | ||||
| RNA_def_property_ui_text( | RNA_def_property_ui_text( | ||||
| prop, "Viewport Shading", "Method to display/shade objects in the 3D View"); | prop, "Viewport Shading", "Display mode for shading the scene"); | ||||
| RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, "rna_3DViewShading_type_update"); | RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, "rna_3DViewShading_type_update"); | ||||
| prop = RNA_def_property(srna, "light", PROP_ENUM, PROP_NONE); | prop = RNA_def_property(srna, "light", PROP_ENUM, PROP_NONE); | ||||
| Context not available. | |||||
| prop = RNA_def_property(srna, "show_xray", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_xray", PROP_BOOLEAN, PROP_NONE); | ||||
| RNA_def_property_boolean_sdna(prop, NULL, "flag", V3D_SHADING_XRAY); | RNA_def_property_boolean_sdna(prop, NULL, "flag", V3D_SHADING_XRAY); | ||||
| RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); | RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); | ||||
| RNA_def_property_ui_text(prop, "Show X-Ray", "Show whole scene transparent"); | RNA_def_property_ui_text(prop, "Viewport X-Ray", "Show whole scene as translucent"); | ||||
brecht: Viewport -> Show Viewport, we should not drop the verb. | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsIf that is the case, it will need to be prefixed with "Show/Hide" because the verb will otherwise be wrong half the time. Alternatively, "Viewport X-Ray On/Off" which is probably a better option. But I don't think it's necessary to break consistency with its neighboring toggles and only use a verb here, because the button being a toggle is obvious enough from its own presence with the blue background when clicked. keavon: If that is the case, it will need to be prefixed with "Show/Hide" because the verb will… | |||||
brechtUnsubmitted Not Done Inline ActionsThe name of the property is what it does when it's enabled. We don't call properties Show/Hide or On/Off. Names of properties can't be set based on assumptions on how they are used in one place in the interface, they are also used for things like quick favorites and Python API docs. We have conventions for naming properties, they should be followed until we decide to change the conventions. brecht: The name of the property is what it does when it's enabled. We don't call properties Show/Hide… | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsThanks for the clarification, that reasoning makes perfect sense to me. I'm also going to change "Viewport Gizmos" to "Show Viewport Gizmos" and "Viewport Overlays" to "Show Viewport Overlays". However, for "Viewport X-Ray" it seems like we should be using "Enable" instead of "Show" because that is a mode that doesn't "show" anything, per se, but it enables a modification to what is already shown (so that the scene becomes shown using the x-ray feature). And likewise, should I change "Snap" into "Enable Snap" and "Proportional Editing Objects" into "Enable Proportional Editing"? If the prefix "Enable" isn't part of the naming conventions like "Show" is, then that could still work but it seems a bit less clear to people reading it. (By the way, interestingly the Viewport X-Ray button actually is missing the option to add it to quick favorites.) keavon: Thanks for the clarification, that reasoning makes perfect sense to me. I'm also going to… | |||||
| RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | ||||
| prop = RNA_def_property(srna, "show_xray_wireframe", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_xray_wireframe", PROP_BOOLEAN, PROP_NONE); | ||||
| RNA_def_property_boolean_sdna(prop, NULL, "flag", V3D_SHADING_XRAY_WIREFRAME); | RNA_def_property_boolean_sdna(prop, NULL, "flag", V3D_SHADING_XRAY_WIREFRAME); | ||||
| RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); | RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); | ||||
| RNA_def_property_ui_text(prop, "Show X-Ray", "Show whole scene transparent"); | RNA_def_property_ui_text(prop, "Viewport X-Ray", "Show whole scene as translucent"); | ||||
| RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | ||||
| prop = RNA_def_property(srna, "xray_alpha", PROP_FLOAT, PROP_FACTOR); | prop = RNA_def_property(srna, "xray_alpha", PROP_FLOAT, PROP_FACTOR); | ||||
| Context not available. | |||||
| prop = RNA_def_property(srna, "show_overlays", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_overlays", PROP_BOOLEAN, PROP_NONE); | ||||
| RNA_def_property_boolean_negative_sdna(prop, NULL, "flag2", V3D_HIDE_OVERLAYS); | RNA_def_property_boolean_negative_sdna(prop, NULL, "flag2", V3D_HIDE_OVERLAYS); | ||||
| RNA_def_property_ui_text(prop, "Show Overlays", "Display overlays like gizmos and outlines"); | RNA_def_property_ui_text(prop, "Viewport Overlays", "Show scene and object overlays"); | ||||
brechtUnsubmitted Not Done Inline ActionsThis description no longer explains what overlays are. brecht: This description no longer explains what overlays are. | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsIt does a better job explaining now than before. We are, of course, limited to short text and cannot give a full wordy description, but this gets the idea across better. The previous phrase "like gizmos and outlines" is 50% wrong, because they are *not* gizmos, and that is extremely confusing because it is, in fact, the wrong word entirely. The other 50% "like outlines" gives only a single example, but we need at least 2–3 other examples to get the idea across descriptively. But that would be too long, and it is a bad UX to describe a feature by a subset of examples. My proposed "scene and object overlays" describes it completely (each and every overlay pertains to either the object—like outlines— or the scene—like grid lines). The only word that can describe all the types of things encompassed by that menu is, in fact, "overlays", so my approach is to narrow down the idea of overlays with the specific classifications they apply to. The user might have to click the button to get a better understanding because there isn't a highly specific English word that magically describes the entire concept, but it is way better to avoid outright confusion from an inconsistent, incomplete example that is currently in use. keavon: It does a better job explaining now than before. We are, of course, limited to short text and… | |||||
brechtUnsubmitted Not Done Inline ActionsThe description can be: Display overlays for selection and editing on top of the scene and objects brecht: The description can be:
```
Display overlays for selection and editing on top of the scene and… | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsHow about Display scene and object overlays for selection and editing? Because that implies they are overlays *about/related to* the scene and objects (as they are "scene and object overlays", and thus also overlaid over the scene and objects), which then encompasses the concept that overlays also include things like the grid and axes, but then it includes your suggested description about "selection and editing" to help the user understand also their purpose. This is also shorter: Display overlays for selection and editing on top of the scene and objects keavon: How about `Display scene and object overlays for selection and editing`? Because that implies… | |||||
| RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, "rna_GPencil_update"); | RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, "rna_GPencil_update"); | ||||
| prop = RNA_def_property(srna, "show_ortho_grid", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_ortho_grid", PROP_BOOLEAN, PROP_NONE); | ||||
| Context not available. | |||||
| prop = RNA_def_property(srna, "show_gizmo", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_gizmo", PROP_BOOLEAN, PROP_NONE); | ||||
| RNA_def_property_boolean_negative_sdna(prop, NULL, "gizmo_flag", V3D_GIZMO_HIDE); | RNA_def_property_boolean_negative_sdna(prop, NULL, "gizmo_flag", V3D_GIZMO_HIDE); | ||||
| RNA_def_property_ui_text(prop, "Show Gizmo", "Show gizmos of all types"); | RNA_def_property_ui_text(prop, "Viewport Gizmos", "Show interactive gizmos"); | ||||
brechtUnsubmitted Not Done Inline ActionsThe description here got lost as well, it's supposed to explain this is a toggle to enable all gizmos, as opposed to the individual toggles for different gizmo types. brecht: The description here got lost as well, it's supposed to explain this is a toggle to enable all… | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsThat is inconsistent with the overlays toggle which makes no attempt to indicate that it is a master toggle. But because of the compact design of these buttons, the user likely won't associate the tool tip for these tiny toggle buttons with the action caused from clicking the tiny button, they will instead associate the tooltip description with the function of the entire menu, so that is what it ought to describe in order to be useful and not confusing (how do the popover menu listings deal with gizmos "of all types"? and is that really the most useful way possible to describe their function?). A classification of "gizmos of all types" doesn't clear up what these "gizmo" things are as a comprehensive classification, but "interactive gizmos" goes much further towards hinting about what they are, and most importantly, how they intuitively differ from overlays, which are not interactive. That's a crucial distinction which will help users tell the two classifications apart. keavon: That is inconsistent with the overlays toggle which makes no attempt to indicate that it is a… | |||||
brechtUnsubmitted Not Done Inline ActionsThe description can be: When disabled, hide all types of interactive gizmos in the viewport brecht: The description can be:
```
When disabled, hide all types of interactive gizmos in the viewport… | |||||
keavonAuthorUnsubmitted Not Done Inline ActionsThat definitely sounds better! I shortened it slightly from:
keavon: That definitely sounds better! I shortened it slightly from:
`When disabled, hide all types of… | |||||
| RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL); | ||||
| prop = RNA_def_property(srna, "show_gizmo_navigate", PROP_BOOLEAN, PROP_NONE); | prop = RNA_def_property(srna, "show_gizmo_navigate", PROP_BOOLEAN, PROP_NONE); | ||||
| Context not available. | |||||
Viewport -> Show Viewport, we should not drop the verb.