Page MenuHome
Differential D5290 Diff 16495 source/blender/alembic/intern/abc_object.cc

Changeset View

Standalone View

View Options

source/blender/alembic/intern/abc_object.cc

Show First 20 Lines • Show All 337 Lines • ▼ Show 20 Lines else {
/* This can happen if the user deleted the parent object. */ /* This can happen if the user deleted the parent object. */
unit_m4(r_mat); unit_m4(r_mat);
} }
} }
else { else {
/* Only apply scaling to root objects, parenting will propagate it. */ /* Only apply scaling to root objects, parenting will propagate it. */
float scale_mat[4][4]; float scale_mat[4][4];
scale_m4_fl(scale_mat, scale); scale_m4_fl(scale_mat, scale);
scale_mat[3][3] = scale; /* scale translations too */ scale_mat[3][3] = scale; /* scale translations too */
brechtUnsubmitted
Done
Inline Actions

This is quite odd, making a non-affine transform for this purpose.

Just switching the order of operations should achieve the same:

float scale_mat[4][4];
scale_m4_fl(scale_mat, scale);
mul_m4_m4m4(r_mat, scale_mat, r_mat);
brecht: This is quite odd, making a non-affine transform for this purpose. Just switching the order of…
sybrenAuthorUnsubmitted
Done
Inline Actions

thanks

sybren: thanks
mul_m4_m4m4(r_mat, r_mat, scale_mat); mul_m4_m4m4(r_mat, r_mat, scale_mat);
r_mat[3][3] = 1.0f; /* Restore w-component of the translation column. */
} }
is_constant = schema.isConstant(); is_constant = schema.isConstant();
} }
void AbcObjectReader::addCacheModifier() void AbcObjectReader::addCacheModifier()
{ {
ModifierData *md = modifier_new(eModifierType_MeshSequenceCache); ModifierData *md = modifier_new(eModifierType_MeshSequenceCache);
Show All 35 Lines