Page MenuHome
Differential D6090 Diff 19102 source/blender/editors/include/ED_screen.h

Changeset View

Standalone View

View Options

source/blender/editors/include/ED_screen.h

Show First 20 Lines • Show All 398 Lines • ▼ Show 20 Linesvoid ED_screen_user_menu_item_add_prop(ListBase *lb,
const char *prop_id, const char *prop_id,
int prop_index); int prop_index);
void ED_screen_user_menu_item_remove(struct ListBase *lb, struct bUserMenuItem *umi); void ED_screen_user_menu_item_remove(struct ListBase *lb, struct bUserMenuItem *umi);
void ED_screen_user_menu_register(void); void ED_screen_user_menu_register(void);
/* Cache display helpers */ /* Cache display helpers */
void ED_region_cache_draw_background(const struct ARegion *ar); void ED_region_cache_draw_background(struct ARegion *ar);
sergeyUnsubmitted
Not Done
Inline Actions

Why to remove const? Is this because some underlying functions don't get const pointer? Would prefer to add const to those.

sergey: Why to remove `const`? Is this because some underlying functions don't get `const` pointer?
lichtwerkAuthorUnsubmitted
Done
Inline Actions

Yes, this was because both ED_region_cache_draw_background and ED_region_cache_draw_cached_segments would now use ED_region_visible_rect.

"Constifying" ED_region_visible_rect is not possible afaict (it alters ar->runtime.visible_rect)

Alternative: let callers of ED_region_cache_draw_background and ED_region_cache_draw_cached_segments calculate region_bottom prior (call ED_region_visible_rect prior) and pass that in? (doesnt look pretty either...)

lichtwerk: Yes, this was because both `ED_region_cache_draw_background` and…
void ED_region_cache_draw_curfra_label(const int framenr, const float x, const float y); void ED_region_cache_draw_curfra_label(const int framenr, const float x, const float y);
void ED_region_cache_draw_cached_segments(const struct ARegion *ar, void ED_region_cache_draw_cached_segments(struct ARegion *ar,
const int num_segments, const int num_segments,
const int *points, const int *points,
const int sfra, const int sfra,
const int efra); const int efra);
/* area_utils.c */ /* area_utils.c */
void ED_region_generic_tools_region_message_subscribe(const struct bContext *C, void ED_region_generic_tools_region_message_subscribe(const struct bContext *C,
struct WorkSpace *workspace, struct WorkSpace *workspace,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines