Page MenuHome
Differential D6647 Diff 21047 build_files/build_environment/patches/openimagedenoise.diff

Changeset View

Standalone View

View Options

build_files/build_environment/patches/openimagedenoise.diff

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
- set(OIDN_STATIC_LIB OFF CACHE BOOL "Build Open Image Denoise as a static library." FORCE) - set(OIDN_STATIC_LIB OFF CACHE BOOL "Build Open Image Denoise as a static library." FORCE)
- mark_as_advanced(OIDN_STATIC_LIB) - mark_as_advanced(OIDN_STATIC_LIB)
-endif() -endif()
+option(OIDN_STATIC_LIB "Build Open Image Denoise as a static library.") +option(OIDN_STATIC_LIB "Build Open Image Denoise as a static library.")
+mark_as_advanced(CLEAR OIDN_STATIC_LIB) +mark_as_advanced(CLEAR OIDN_STATIC_LIB)
if(OIDN_STATIC_LIB) if(OIDN_STATIC_LIB)
set(OIDN_LIB_TYPE STATIC) set(OIDN_LIB_TYPE STATIC)
else() else()
diff -Naur orig/core/api.cpp external_openimagedenoise/core/api.cpp
--- orig/core/api.cpp 2019-07-19 08:37:04 -0600
+++ external_openimagedenoise/core/api.cpp 2020-01-21 15:10:56 -0700
@@ -15,7 +15,7 @@
// ======================================================================== //
#ifdef _WIN32
-# define OIDN_API extern "C" __declspec(dllexport)
+# define OIDN_API extern "C"
#else
# define OIDN_API extern "C" __attribute__ ((visibility ("default")))
sergeyUnsubmitted
Not Done
Inline Actions

Shouldn't we also "hide" symbols on non-windows?

sergey: Shouldn't we also "hide" symbols on non-windows?
LazyDodoAuthorUnsubmitted
Done
Inline Actions

Dunno, depends a bit on how clean of a ship we'd want to run, symbol visibility on gcc for the longest time was EXPORT ALL THE THINGS! and it still is unless you pass -fvisibility=hidden

`#nm -D ./blender | grep " T " | wc -l
84291`

seems to indicate that symbol visibility is not something we have looked at in the past on linux.

LazyDodo: Dunno, depends a bit on how clean of a ship we'd want to run, symbol visibility on gcc for the…
sergeyUnsubmitted
Not Done
Inline Actions

Seems to indicate that symbol visibility is not something we have looked at in the past on Linux.

That is correct.

Just a bit weird we start addressing it on Windows but not on Linux.
But can do it when Linux time have time to make sure everything works. No need to hold Windows changes.

Was just curious, you know ;)

sergey: > Seems to indicate that symbol visibility is not something we have looked at in the past on…
#endif