Differential D7017 Diff 22354 tests/python/modules/mesh_test.py

Changeset View

Standalone View

tests/python/modules/mesh_test.py

Context not available.
	return "Modifier: " + self.modifier_name + " of type " + self.modifier_type + \	return "Modifier: " + self.modifier_name + " of type " + self.modifier_type + \
	" with parameters: " + str(self.modifier_parameters)	" with parameters: " + str(self.modifier_parameters)

		class PhysicsSpec:
		"""
		Holds one modifier and its parameters.
		"""
		brechtUnsubmitted Not Done Inline Actions modifier -> physics modifier brecht: modifier -> physics modifier

		def __init__(self, modifier_name: str, modifier_type: str, modifier_parameters: dict,frame_end:int):
		"""
		Constructs a physics spec.
		:param modifier_name: str - name of object modifier, e.g. "Cloth"
		:param modifier_type: str - type of object modifier, e.g. "CLOTH"
		:param modifier_parameters: dict - {name : val} dictionary giving modifier parameters, e.g. {"quality" : 4}
		:param frame_end:int - the last frame of the simulation at which it is baked
		"""
		self.modifier_name = modifier_name
		self.modifier_type = modifier_type
		self.modifier_parameters = modifier_parameters
		self.frame_end = frame_end

		def __str__(self):
		return "Modifier: " + self.modifier_name + " of type " + self.modifier_type + \
		" with parameters: " + str(self.modifier_parameters) + " with frame number: "+str(self.frame_number)
		brechtUnsubmitted Done Inline Actions `frame_number` -> `frame_end` brecht: `frame_number` -> `frame_end`
		brechtUnsubmitted Done Inline Actions Modifier -> Physics Modifier brecht: Modifier -> Physics Modifier

	class OperatorSpec:	class OperatorSpec:
	"""	"""
Context not available.
	if self.apply_modifier:	if self.apply_modifier:
	bpy.ops.object.modifier_apply(modifier=modifier_spec.modifier_name)	bpy.ops.object.modifier_apply(modifier=modifier_spec.modifier_name)


		def bake_current_simulation(self,obj,test_mod_type,test_mod_name,frame_end):

		brechtUnsubmitted Done Inline Actions Code style: no empty line right after `def` line. brecht: Code style: no empty line right after `def` line.
		for scene in bpy.data.scenes:

		for modifier in obj.modifiers:
		brechtUnsubmitted Done Inline Actions Two empty lines still here. brecht: Two empty lines still here.
		if modifier.type == test_mod_type:
		obj.modifiers[test_mod_name].point_cache.frame_end = frame_end
		override = {'scene': scene, 'active_object': obj, 'point_cache': modifier.point_cache}
		bpy.ops.ptcache.bake(override, bake=True)
		break

		def _apply_physics_settings(self, test_object, physics_spec: PhysicsSpec):


		bpy.ops.screen.frame_jump(end=False)
		brechtUnsubmitted Done Inline Actions Avoid using operators when possible, this can probably be `scene.frame_set` or similar? It's not even clear to me what this line does, which frame is it supposed to jump to? brecht: Avoid using operators when possible, this can probably be `scene.frame_set` or similar? It's…
		modifier = test_object.modifiers.new(physics_spec.modifier_name,
		physics_spec.modifier_type)
		physics_setting = modifier.settings
		if self.verbose:
		print("Created modifier '{}' of type '{}'.".
		format(physics_spec.modifier_name, physics_spec.modifier_type))



		brechtUnsubmitted Done Inline Actions Code style: use only one empty line as separator inside functions. brecht: Code style: use only one empty line as separator inside functions.
		for param_name in physics_spec.modifier_parameters:
		try:

		setattr(physics_setting, param_name, physics_spec.modifier_parameters[param_name])

		if self.verbose:
		print("\t set parameter '{}' with value '{}'".
		format(param_name, physics_spec.modifier_parameters[param_name]))
		except AttributeError:
		# Clean up first
		bpy.ops.object.delete()
		raise AttributeError("Modifier '{}' has no parameter named '{}'".
		format(physics_spec.modifier_type, param_name))

		bpy.ops.screen.frame_offset(delta=(physics_spec.frame_end+1))
		brechtUnsubmitted Done Inline Actions This can also just call `scene.frame_set`? brecht: This can also just call `scene.frame_set`?

		self.bake_current_simulation(test_object,physics_spec.modifier_type,physics_spec.modifier_name, physics_spec.frame_end)
		brechtUnsubmitted Not Done Inline Actions Easier to just pass the `physics_spec` entirely to this function. brecht: Easier to just pass the `physics_spec` entirely to this function.
		calraAuthorUnsubmitted Done Inline Actions Accessing using `physics_spec` feels unnecessarily long. calra: Accessing using `physics_spec` feels unnecessarily long.
		if self.apply_modifier:
		bpy.ops.object.modifier_apply(modifier=physics_spec.modifier_name)


	def _apply_operator(self, test_object, operator: OperatorSpec):	def _apply_operator(self, test_object, operator: OperatorSpec):
	"""	"""
	Apply operator on test object.	Apply operator on test object.
Context not available.

	elif isinstance(operation, OperatorSpec):	elif isinstance(operation, OperatorSpec):
	self._apply_operator(evaluated_test_object, operation)	self._apply_operator(evaluated_test_object, operation)

		elif isinstance(operation, PhysicsSpec):
		self._apply_physics_settings(evaluated_test_object, operation)
	else:	else:
	raise ValueError("Expected operation of type {} or {}. Got {}".	raise ValueError("Expected operation of type {} or {} or {}. Got {}".
	format(type(ModifierSpec), type(OperatorSpec),	format(type(ModifierSpec), type(OperatorSpec), type(PhysicsSpec),
	type(operation)))	type(operation)))

	# Compare resulting mesh with expected one.	# Compare resulting mesh with expected one.
Context not available.