Differential D7024 Diff 22752 source/blender/editors/space_view3d/space_view3d.c

Changeset View

Standalone View

source/blender/editors/space_view3d/space_view3d.c

Show First 20 Lines • Show All 430 Lines • ▼ Show 20 Lines	static void view3d_main_region_init(wmWindowManager wm, ARegion region)
WM_event_add_dropbox_handler(&region->handlers, lb);		WM_event_add_dropbox_handler(&region->handlers, lb);
}		}

static void view3d_main_region_exit(wmWindowManager wm, ARegion region)		static void view3d_main_region_exit(wmWindowManager wm, ARegion region)
{		{
ED_view3d_stop_render_preview(wm, region);		ED_view3d_stop_render_preview(wm, region);
}		}

static bool view3d_ob_drop_poll(bContext *UNUSED(C),		static bool view3d_drop_id_in_main_region_poll(bContext *C,
wmDrag *drag,		wmDrag *drag,
const wmEvent *UNUSED(event),		const wmEvent *event,
		ID_Type id_type)
		{
		ScrArea *area = CTX_wm_area(C);
		if (ED_region_overlap_isect_any_xy(area, &event->x)) {
		return false;
		}
		brechtUnsubmitted Not Done Inline Actions Can we make this a bit more generic? Loop over regions in `ScrArea`, then check if they are overlapping with `ED_region_is_overlap`. Ideally this can then also be implemented in `wm_dragdrop.c` so it works for all editors that might have overlapping regions, which includes the image editor. brecht: Can we make this a bit more generic? Loop over regions in `ScrArea`, then check if they are…
		return WM_drag_ID(drag, id_type) != NULL;
		}

		static bool view3d_ob_drop_poll(bContext *C,
		wmDrag *drag,
		const wmEvent *event,
const char **UNUSED(tooltip))		const char **UNUSED(tooltip))
{		{
return WM_drag_ID(drag, ID_OB) != NULL;		return view3d_drop_id_in_main_region_poll(C, drag, event, ID_OB);
}		}

static bool view3d_collection_drop_poll(bContext *UNUSED(C),		static bool view3d_collection_drop_poll(bContext *C,
wmDrag *drag,		wmDrag *drag,
const wmEvent *UNUSED(event),		const wmEvent *event,
const char **UNUSED(tooltip))		const char **UNUSED(tooltip))
{		{
return WM_drag_ID(drag, ID_GR) != NULL;		return view3d_drop_id_in_main_region_poll(C, drag, event, ID_GR);
}		}

static bool view3d_mat_drop_poll(bContext *UNUSED(C),		static bool view3d_mat_drop_poll(bContext *C,
wmDrag *drag,		wmDrag *drag,
const wmEvent *UNUSED(event),		const wmEvent *event,
const char **UNUSED(tooltip))		const char **UNUSED(tooltip))
{		{
return WM_drag_ID(drag, ID_MA) != NULL;		return view3d_drop_id_in_main_region_poll(C, drag, event, ID_MA);
}		}

static bool view3d_ima_drop_poll(bContext *UNUSED(C),		static bool view3d_ima_drop_poll(bContext *C,
wmDrag *drag,		wmDrag *drag,
const wmEvent *UNUSED(event),		const wmEvent *event,
const char **UNUSED(tooltip))		const char **UNUSED(tooltip))
{		{
		if (ED_region_overlap_isect_any_xy(CTX_wm_area(C), &event->x)) {
		return false;
		}
if (drag->type == WM_DRAG_PATH) {		if (drag->type == WM_DRAG_PATH) {
/* rule might not work? */		/* rule might not work? */
return (ELEM(drag->icon, 0, ICON_FILE_IMAGE, ICON_FILE_MOVIE));		return (ELEM(drag->icon, 0, ICON_FILE_IMAGE, ICON_FILE_MOVIE));
}		}
else {		else {
return WM_drag_ID(drag, ID_IM) != NULL;		return WM_drag_ID(drag, ID_IM) != NULL;
}		}
}		}
▲ Show 20 Lines • Show All 1,143 Lines • Show Last 20 Lines