Changeset View
Standalone View
tests/python/modules/transform_test.py
- This file was added.
| # ##### BEGIN GPL LICENSE BLOCK ##### | |||||
| # | |||||
| # This program is free software; you can redistribute it and/or | |||||
| # modify it under the terms of the GNU General Public License | |||||
| # as published by the Free Software Foundation; either version 2 | |||||
| # of the License, or (at your option) any later version. | |||||
| # | |||||
| # This program is distributed in the hope that it will be useful, | |||||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | |||||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||||
| # GNU General Public License for more details. | |||||
| # | |||||
| # You should have received a copy of the GNU General Public License | |||||
| # along with this program; if not, write to the Free Software Foundation, | |||||
| # Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||||
| # | |||||
| # ##### END GPL LICENSE BLOCK ##### | |||||
| # <pep8 compliant> | |||||
| import bpy | |||||
| import os | |||||
sybren: The function tries to find a 3D View. This should be clear from the name, and if that's not… | |||||
| def get_area(): | |||||
| for area in bpy.context.screen.areas: | |||||
| if area.type == 'VIEW_3D': | |||||
Done Inline ActionsNever, ever use a plain raise. Choose the appropriate exception type, and pass it an explanation of what's going wrong. sybren: Never, ever use a plain `raise`. Choose the appropriate exception type, and pass it an… | |||||
Done Inline ActionsOf course this comment also applies to all the other plain raise invocations. sybren: Of course this comment also applies to all the other plain `raise` invocations.
| |||||
| return area | |||||
| raise | |||||
| def get_region_window(area): | |||||
| for region in area.regions: | |||||
| if region.type == 'WINDOW': | |||||
| return region | |||||
| raise | |||||
| def get_rv3d(area): | |||||
| for space in area.spaces: | |||||
| if space.type == 'VIEW_3D': | |||||
| return space.region_3d | |||||
| raise | |||||
| class TestCompare: | |||||
| __slots__ = ( | |||||
| "obj_a", | |||||
Done Inline ActionsSince this class is contained in a test-specific file, and it's not a test itself, there is not really a need to have "Test" in the name. MeshCompare or ObjectCompare or something along those lines would be better. sybren: Since this class is contained in a test-specific file, and it's not a test itself, there is not… | |||||
| "obj_b", | |||||
| "compare_matrix", | |||||
| "compare_data", | |||||
Done Inline ActionsNo need to repeat what's already in the __init__(); these kind of comments tend to rot quickly. I think it's more important to describe what compare_data actually means. sybren: No need to repeat what's already in the `__init__()`; these kind of comments tend to rot… | |||||
| "description", | |||||
| ) | |||||
| def __init__(self, obj_a, obj_b, compare_matrix=False, compare_data=False, description=""): | |||||
| self.obj_a = obj_a | |||||
| self.obj_b = obj_b | |||||
| self.compare_matrix = compare_matrix | |||||
| self.compare_data = compare_data | |||||
| self.description = description | |||||
| def run(self, index, verbose=True): | |||||
| if verbose: | |||||
| print("Test comparison {}: {}".format(index, self.description)) | |||||
| compare_success = True | |||||
| compare_result = '' | |||||
| if self.compare_matrix: | |||||
| mat_diff = self.obj_a.matrix_world - self.obj_b.matrix_world | |||||
| for f in mat_diff: | |||||
Done Inline ActionsDon't use single-letter names. sybren: Don't use single-letter names. | |||||
| for f in f: | |||||
Done Inline ActionsDon't change the type associated with a name. What's wrong with a loop like for row in mat_diff: for value_diff in row:? sybren: Don't change the type associated with a name.
What's wrong with a loop like `for row in… | |||||
| if abs(f) > 0.0001: | |||||
| compare_success = False | |||||
| break | |||||
| compare_success = self.obj_a.matrix_world == self.obj_b.matrix_world | |||||
| if compare_success and self.compare_data: | |||||
Done Inline ActionsHaving break/else/continue/break on consecutive lines makes it really hard to follow what's going on. Move this code into its own function, then you can replace the first break with a return and all the other keywords can go. sybren: Having `break/else/continue/break` on consecutive lines makes it really hard to follow what's… | |||||
| mesh_a = self.obj_a.data | |||||
| mesh_b = self.obj_b.data | |||||
| compare_result = mesh_a.unit_test_compare(mesh=mesh_b) | |||||
| compare_success = (compare_result == 'Same') | |||||
Done Inline ActionsThe fact that only mesh objects are supported, and that self.compare_data actually means self.compare_meshes should be documented. sybren: The fact that only mesh objects are supported, and that `self.compare_data` actually means… | |||||
| if compare_success: | |||||
Done Inline ActionsThis should also be its own function. sybren: This should also be its own function. | |||||
| if verbose: | |||||
| print("Success!") | |||||
| return True | |||||
| else: | |||||
| print("Test comparison result: {}".format(compare_result)) | |||||
| print("Resulting object '{}' did not match expected object '{}' from file {}". | |||||
| format(self.obj_a.name, self.obj_b.name, bpy.data.filepath)) | |||||
| return False | |||||
| class TestContext: | |||||
| __slots__ = ( | |||||
| "override_context", | |||||
| "funcs", | |||||
| "verbose", | |||||
| "cleanup", | |||||
| "dupli_objects", | |||||
| "compare_queue", | |||||
| ) | |||||
| def __init__(self, funcs): | |||||
| context = bpy.context | |||||
| area = get_area() | |||||
| region = get_region_window(area) | |||||
| self.override_context = {'area':area, 'region':region} | |||||
| self.funcs = funcs | |||||
| self.verbose = os.environ.get("BLENDER_VERBOSE") is not None | |||||
Done Inline ActionsNo need to do a late import here. sybren: No need to do a late import here.
| |||||
| self.cleanup = True | |||||
| self.dupli_objects = [] | |||||
| self.compare_queue = [] | |||||
| def object_mode_delayed_func(self, scene, depsgraph): | |||||
| # Call only once. | |||||
| bpy.app.handlers.depsgraph_update_pre.remove(self.object_mode_delayed_func) | |||||
| self.default_settings_set() | |||||
| failed = [] | |||||
| for i, comparison in enumerate(self.compare_queue): | |||||
| sucess = comparison.run(i, self.verbose) | |||||
| if not sucess: | |||||
| failed.append(i) | |||||
| if self.cleanup: | |||||
| self.default_settings_set() | |||||
| self.activate_object(self.dupli_objects[0]) | |||||
| for obj_dupl in self.dupli_objects: | |||||
| obj_dupl.select_set(True) | |||||
| bpy.ops.object.delete() | |||||
| self.compare_queue.clear() | |||||
| if failed: | |||||
| if self.verbose: | |||||
| tot = len(failed) | |||||
| print('Ran', tot, 'tests,' if tot > 1 else 'test,', failed, 'failed') | |||||
| raise Exception("Tests {} failed".format(failed)) | |||||
| def default_settings_set(self): | |||||
| rv3d = get_rv3d(self.override_context['area']) | |||||
| if rv3d.view_perspective != 'CAMERA': | |||||
| bpy.ops.view3d.view_camera(self.override_context) | |||||
| scene = bpy.context.scene | |||||
Done Inline ActionsIf I read the code correctly, ret can get two values: None and 0.0. These are not exactly meaningful values, and the handling of ret is not None is so far away from ret = 0.0 that it makes it hard to understand what exactly is going on. sybren: If I read the code correctly, `ret` can get two values: `None` and `0.0`. These are not exactly… | |||||
Done Inline ActionsThis method is the callback used in timers (I will move it closer, improve description and change the name to make it clear). When a timers callback returns None, it is unregistered. If the return is a float, the float value represents the minimum time for the test to be run again. The fact that the tests need to run on a timers callback makes it difficult to use with unittest module. Unfortunately this is the only way I have found to be able to use --event-simulate in tests. (This is also done in other test files). mano-wii: This method is the callback used in timers (I will move it closer, improve description and… | |||||
| tool_settings = scene.tool_settings | |||||
| scene.transform_orientation_slots[0].type = 'GLOBAL' | |||||
| tool_settings.transform_pivot_point = 'MEDIAN_POINT' | |||||
| tool_settings.snap_elements = {'INCREMENT'} | |||||
| tool_settings.use_snap = False | |||||
| tool_settings.use_snap_grid_absolute = False | |||||
| tool_settings.use_snap_translate = True | |||||
| tool_settings.use_snap_rotate = False | |||||
| tool_settings.use_snap_scale = False | |||||
| tool_settings.use_proportional_edit_objects = False | |||||
| tool_settings.proportional_edit_falloff = 'SMOOTH' | |||||
| if bpy.context.mode != 'OBJECT': | |||||
| bpy.ops.object.mode_set(mode='OBJECT') | |||||
| bpy.ops.object.select_all(action="DESELECT") | |||||
| def compare_data_add(self, obj_a, obj_b, description): | |||||
| self.compare_queue.append(TestCompare(obj_a, obj_b, compare_data=True, description=description)) | |||||
| def compare_matrix_add(self, obj_a, obj_b, description): | |||||
| self.compare_queue.append(TestCompare(obj_a, obj_b, compare_matrix=True, description=description)) | |||||
| def activate_object(self, obj): | |||||
| mode = bpy.context.mode | |||||
| if mode != 'OBJECT': | |||||
| bpy.ops.object.mode_set(mode="OBJECT") | |||||
| bpy.ops.object.select_all(action="DESELECT") | |||||
| bpy.context.view_layer.objects.active = obj | |||||
| obj.select_set(True) | |||||
| if mode == 'EDIT_MESH': | |||||
| bpy.ops.object.mode_set(mode="EDIT") | |||||
| def duplicate_object(self, obj): | |||||
| mode = bpy.context.mode | |||||
| if mode != 'OBJECT': | |||||
| bpy.ops.object.mode_set(mode="OBJECT") | |||||
| self.activate_object(obj) | |||||
| bpy.ops.object.duplicate() | |||||
| if mode == 'EDIT_MESH': | |||||
| bpy.ops.object.mode_set(mode="EDIT") | |||||
| obj_dupl = bpy.context.active_object | |||||
| self.dupli_objects.append(obj_dupl) | |||||
| return obj_dupl | |||||
| def end(self): | |||||
Done Inline ActionsWhat is this mapping for? sybren: What is this mapping for? | |||||
Done Inline ActionsBlender should use a consistent enum for "mode", no matter if it is the mode in the context or the mode of the object. I will split things. mano-wii: Blender should use a consistent enum for "mode", no matter if it is the mode in the context or… | |||||
| bpy.app.handlers.depsgraph_update_pre.append(self.object_mode_delayed_func) | |||||
Done Inline ActionsParentheses aren't necessary here. Same for other if-statements. sybren: Parentheses aren't necessary here. Same for other `if`-statements. | |||||
The function tries to find a 3D View. This should be clear from the name, and if that's not possible, from a docstring.