Page MenuHome
Differential D7679 Diff 24572 source/blender/editors/space_sequencer/sequencer_select.c

Changeset View

Standalone View

View Options

source/blender/editors/space_sequencer/sequencer_select.c

Context not available.
x = CFRA - 1.0f; x = CFRA - 1.0f;
break; break;
case SEQ_SELECT_LR_RIGHT: case SEQ_SELECT_LR_RIGHT:
x = CFRA + 1.0f;
break;
case SEQ_SELECT_LR_CENTER:
default: default:
x = CFRA; x = CFRA;
break; break;
} }
SEQP_BEGIN (ed, seq) { SEQP_BEGIN (ed, seq) {
if (((x < CFRA) && (seq->enddisp <= CFRA)) || ((x >= CFRA) && (seq->startdisp >= CFRA))) { if (((x == CFRA) && (seq->startdisp <= CFRA) && (seq->enddisp >= CFRA))) {
seq->flag = SELECT;
recurs_sel_seq(seq);
}
else if (((x < CFRA) && (seq->enddisp <= CFRA)) || ((x > CFRA) && (seq->startdisp >= CFRA))) {
seq->flag |= SELECT; seq->flag |= SELECT;
recurs_sel_seq(seq); recurs_sel_seq(seq);
} }
Context not available.
{SEQ_SELECT_LR_MOUSE, "MOUSE", 0, "Mouse", "Use mouse position for selection"}, {SEQ_SELECT_LR_MOUSE, "MOUSE", 0, "Mouse", "Use mouse position for selection"},
{SEQ_SELECT_LR_LEFT, "LEFT", 0, "Left", "Select left"}, {SEQ_SELECT_LR_LEFT, "LEFT", 0, "Left", "Select left"},
{SEQ_SELECT_LR_RIGHT, "RIGHT", 0, "Right", "Select right"}, {SEQ_SELECT_LR_RIGHT, "RIGHT", 0, "Right", "Select right"},
{SEQ_SELECT_LR_CENTER, "CENTER", 0, "Center", "Select center"},
{0, NULL, 0, NULL, NULL}, {0, NULL, 0, NULL, NULL},
}; };
PropertyRNA *prop; PropertyRNA *prop;
Context not available.
ISSUnsubmitted
Done
Inline Actions

Option "center" doesn't really make sense. I guess something like "intersecting" or "under playhead" would be better.

ISS: Option "center" doesn't really make sense. I guess something like "intersecting" or "under…
tintwotinAuthorUnsubmitted
Done
Inline Actions

Since the menu is called Playhead > Left/Right, I guess "Under" would be enough?

tintwotin: Since the menu is called Playhead > Left/Right, I guess "Under" would be enough?
ISSUnsubmitted
Done
Inline Actions

I think it's enough for UI, though it would be better if it was called explicitly under playhead when used in code - it's more readable.
{SEQ_SELECT_LR_UNDER_PLAYHEAD, "UNDER_PLAYHEAD", 0, "Under", "Select under"},

Even description for those 3 options could be updated to Select left to playhead, Select right to playhead and Select under playhead

After all these operators could exist outside of menu providing context (custom addon) where it is nicer to hover on top of button to see what it actually does.

ISS: I think it's enough for UI, though it would be better if it was called explicitly under…