Differential D643 Diff 2100 source/blender/gpu/GPU_extensions.h

Changeset View

Standalone View

source/blender/gpu/GPU_extensions.h

Context not available.
	extern "C" {	extern "C" {
	#endif	#endif

		#include "BLI_sys_types.h" /* for bool */
		sergeyUnsubmitted Not Done Inline Actions I don't see bool in this header. sergey: I don't see bool in this header.
		jwilkinsUnsubmitted Not Done Inline Actions I removed the function that needs it, but missed removing this include as well. jwilkins: I removed the function that needs it, but missed removing this include as well.

	struct Image;	struct Image;
	struct ImageUser;	struct ImageUser;
	struct PreviewImage;	struct PreviewImage;
Context not available.
	/* GPU extensions support */	/* GPU extensions support */

	void GPU_extensions_disable(void);	void GPU_extensions_disable(void);
	void GPU_extensions_init(void); /* call this before running any of the functions below */	void gpu_extensions_init(void); /* call this before running any of the functions below */
		sergeyUnsubmitted Not Done Inline Actions What's the point of making it lowercase? sergey: What's the point of making it lowercase?
		jwilkinsUnsubmitted Not Done Inline Actions Uppercase GPU_ means it is part of the interface while gpu_ is an internal function. GPU_extensions_init has been replaced with GPU_init. jwilkins: Uppercase GPU_ means it is part of the interface while gpu_ is an internal function.
		campbellbartonUnsubmitted Not Done Inline Actions Convention here is only use lowercase names in this fashion for local `static` functions. campbellbarton: Convention here is only use lowercase names in this fashion for local `static` functions.
		jwilkinsUnsubmitted Not Done Inline Actions That seems to contradict what Brecht told me. jwilkins: That seems to contradict what Brecht told me.
		campbellbartonUnsubmitted Not Done Inline Actions Okay, this is internal but shared between C files, moved into own private header (rB9c9efe7a36aecc3e79f614778433f855fc5174c8) campbellbarton: Okay, this is internal but shared between C files, moved into own private header…
	void GPU_extensions_exit(void);	void gpu_extensions_exit(void);
	int GPU_print_error(const char *str);	int GPU_print_error(const char *str);

	int GPU_glsl_support(void);	int GPU_glsl_support(void);
Context not available.