Page MenuHome
Differential D8159 Diff 26396 source/blender/editors/space_buttons/space_buttons.c

Changeset View

Standalone View

View Options

source/blender/editors/space_buttons/space_buttons.c

Show First 20 Lines • Show All 407 Lines • ▼ Show 20 Lines case NC_OBJECT:
buttons_area_redraw(area, BCONTEXT_BONE); buttons_area_redraw(area, BCONTEXT_BONE);
buttons_area_redraw(area, BCONTEXT_BONE_CONSTRAINT); buttons_area_redraw(area, BCONTEXT_BONE_CONSTRAINT);
buttons_area_redraw(area, BCONTEXT_DATA); buttons_area_redraw(area, BCONTEXT_DATA);
break; break;
case ND_MODIFIER: case ND_MODIFIER:
if (wmn->action == NA_RENAME) { if (wmn->action == NA_RENAME) {
ED_area_tag_redraw(area); ED_area_tag_redraw(area);
} }
else { else {
buttons_area_redraw(area, BCONTEXT_MODIFIER); buttons_area_redraw(area, BCONTEXT_MODIFIER);
} }
SeverinUnsubmitted
Done
Inline Actions
ED_area_tag_redraw(area);
}
else {
buttons_area_redraw(area, BCONTEXT_MODIFIER);
+ buttons_area_redraw(area, BCONTEXT_SHADERFX);
}
buttons_area_redraw(area, BCONTEXT_PHYSICS);

Wouldn't just adding this be an alternative fix?
Did you try that?

I think it's fine to decouple notifers though. Allows more fine-tuned updates and it's easier to reason about things. So adding a SHADERFX notifier type is fine with me too. But if this simple fix is possible, you should at least mention why you didn't choose it in the commit message.

Severin: Wouldn't just adding this be an alternative fix? Did you try that? I think it's fine to…
HooglyBooglyAuthorUnsubmitted
Done
Inline Actions

Yeah, I think it makes more sense to keep them decoupled. We can avoid some updates like that, and more that I didn't catch that you mentioned below. I'll note it in the commit.

HooglyBoogly: Yeah, I think it makes more sense to keep them decoupled. We can avoid some updates like that…
buttons_area_redraw(area, BCONTEXT_PHYSICS); buttons_area_redraw(area, BCONTEXT_PHYSICS);
break; break;
case ND_CONSTRAINT: case ND_CONSTRAINT:
buttons_area_redraw(area, BCONTEXT_CONSTRAINT); buttons_area_redraw(area, BCONTEXT_CONSTRAINT);
buttons_area_redraw(area, BCONTEXT_BONE_CONSTRAINT); buttons_area_redraw(area, BCONTEXT_BONE_CONSTRAINT);
break; break;
case ND_SHADERFX:
buttons_area_redraw(area, BCONTEXT_SHADERFX);
buttons_area_redraw(area, BCONTEXT_SHADERFX);
SeverinUnsubmitted
Done
Inline Actions

Function call is duplicated.

Severin: Function call is duplicated.
break;
case ND_PARTICLE: case ND_PARTICLE:
if (wmn->action == NA_EDITED) { if (wmn->action == NA_EDITED) {
buttons_area_redraw(area, BCONTEXT_PARTICLE); buttons_area_redraw(area, BCONTEXT_PARTICLE);
} }
sbuts->preview = 1; sbuts->preview = 1;
break; break;
case ND_DRAW: case ND_DRAW:
buttons_area_redraw(area, BCONTEXT_OBJECT); buttons_area_redraw(area, BCONTEXT_OBJECT);
▲ Show 20 Lines • Show All 256 Lines • Show Last 20 Lines