Changeset View

Standalone View

				from django.contrib.flatpages.models import FlatPage
				from django.db import models

				from common import mixins, markdown
				from films.models import Film


				class ExtendedFlatPage(mixins.CreatedUpdatedMixin, FlatPage):
				html_content = models.TextField(blank=True, editable=False)
				sybrenUnsubmitted Not Done Inline Actions The name doesn't convey anything about the purpose of this class, beyond the fact that it has a few extra properties. Currently there are multiple things happening in this class: It changes the content type of the `FlatPage.content` field from HTML to MarkDown. It connects the page to a specific Film, and ensures deletion of the page on deletion of that film. This looks like it could be split up in two classes, one for each 'thing'. I think that the content type change to MarkDown could be moved into a mix-in class and placed in the `common.models` module. sybren: The name doesn't convey anything about the purpose of this class, beyond the fact that it has a…
				film = models.ForeignKey(Film, on_delete=models.CASCADE, related_name='flatpages')

				def clean(self) -> None:
				super().clean()
				self.html_content = markdown.render(self.content)