Page MenuHome
Differential D8415 Diff 27251 source/blender/blenkernel/intern/mesh_runtime.c

Changeset View

Standalone View

View Options

source/blender/blenkernel/intern/mesh_runtime.c

Context not available.
/** \name Mesh Runtime Struct Utils /** \name Mesh Runtime Struct Utils
* \{ */ * \{ */
static ThreadRWMutex loops_cache_lock = PTHREAD_RWLOCK_INITIALIZER;
/** /**
* Default values defined at read time. * Default values defined at read time.
*/ */
Context not available.
{ {
MLoopTri *looptri; MLoopTri *looptri;
BLI_rw_mutex_lock(&loops_cache_lock, THREAD_LOCK_READ); ThreadMutex *mesh_eval_mutex = (ThreadMutex *)mesh->runtime.eval_mutex;
BLI_mutex_lock(mesh_eval_mutex);
looptri = mesh->runtime.looptris.array; looptri = mesh->runtime.looptris.array;
BLI_rw_mutex_unlock(&loops_cache_lock);
if (looptri != NULL) { if (looptri != NULL) {
BLI_assert(BKE_mesh_runtime_looptri_len(mesh) == mesh->runtime.looptris.len); BLI_assert(BKE_mesh_runtime_looptri_len(mesh) == mesh->runtime.looptris.len);
} }
else { else {
BLI_rw_mutex_lock(&loops_cache_lock, THREAD_LOCK_WRITE); BKE_mesh_runtime_looptri_recalc(mesh);
/* We need to ensure array is still NULL inside mutex-protected code,
* some other thread might have already recomputed those looptris. */
if (mesh->runtime.looptris.array == NULL) {
BKE_mesh_runtime_looptri_recalc(mesh);
}
looptri = mesh->runtime.looptris.array; looptri = mesh->runtime.looptris.array;
BLI_rw_mutex_unlock(&loops_cache_lock);
} }
sergeyUnsubmitted
Done
Inline Actions

This is some weird residue of the double-checked-lock patter.
Either follow the pattern ,or remove its reidue.

sergey: This is some weird residue of the double-checked-lock patter. Either follow the pattern ,or…
BLI_mutex_unlock(mesh_eval_mutex);
return looptri; return looptri;
} }
Context not available.