Page MenuHome
Differential D8966 Diff 29105 source/blender/makesrna/intern/rna_modifier.c

Changeset View

Standalone View

View Options

source/blender/makesrna/intern/rna_modifier.c

Context not available.
StructRNA *srna; StructRNA *srna;
PropertyRNA *prop; PropertyRNA *prop;
static const EnumPropertyItem mode_items[] = {
{MOD_WELD_SIMPLE_MODE, "SIMPLE", 0, "Simple", "Only merge along the surface and boundaries"},
{MOD_WELD_FULL_MODE, "FULL", 0, "Full", "Full merge by distance (slow)"},
{0, NULL, 0, NULL, NULL},
brechtUnsubmitted
Not Done
Inline Actions

Perhaps better naming would be:

  • Connected: Only merged connected vertices within the distance
  • All: Merge all vertices within the distance (slower)

Simple & Full don't really explain what this does, and I think merging only connected geometry may in some cases be the desired behavior rather than just a performance optimization.

brecht: Perhaps better naming would be: * Connected: Only merged connected vertices within the distance…
weaselAuthorUnsubmitted
Done
Inline Actions

Agreed. @Germano Cavalcante (mano-wii) as you want to work on the names later anyway, should I do it now or do you want to do this?

weasel: Agreed. @mano-wii as you want to work on the names later anyway, should I do it now or do you…
};
srna = RNA_def_struct(brna, "WeldModifier", "Modifier"); srna = RNA_def_struct(brna, "WeldModifier", "Modifier");
RNA_def_struct_ui_text(srna, "Weld Modifier", "Weld modifier"); RNA_def_struct_ui_text(srna, "Weld Modifier", "Weld modifier");
RNA_def_struct_sdna(srna, "WeldModifierData"); RNA_def_struct_sdna(srna, "WeldModifierData");
Context not available.
"(0 makes it infinite)"); "(0 makes it infinite)");
RNA_def_property_update(prop, 0, "rna_Modifier_update"); RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "mode", PROP_ENUM, PROP_NONE);
RNA_def_property_enum_items(prop, mode_items);
RNA_def_property_ui_text(prop, "Mode", "Mode defines the merge rule.");
RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "vertex_group", PROP_STRING, PROP_NONE); prop = RNA_def_property(srna, "vertex_group", PROP_STRING, PROP_NONE);
RNA_def_property_string_sdna(prop, NULL, "defgrp_name"); RNA_def_property_string_sdna(prop, NULL, "defgrp_name");
RNA_def_property_ui_text( RNA_def_property_ui_text(
Context not available.
RNA_def_property_ui_text(prop, "Invert", "Invert vertex group influence"); RNA_def_property_ui_text(prop, "Invert", "Invert vertex group influence");
RNA_def_property_update(prop, 0, "rna_Modifier_update"); RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "only_boundary", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOD_WELD_FULL_ONLY_BOUNDARY);
RNA_def_property_ui_text(prop, "Only Boundary", "Weld only boundary edges");
RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "do_boundary", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOD_WELD_SIMPLE_DO_BOUNDARY);
RNA_def_property_ui_text(prop, "Weld Boundary", "Weld boundary edges");
RNA_def_property_update(prop, 0, "rna_Modifier_update");
prop = RNA_def_property(srna, "do_inside", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, NULL, "flag", MOD_WELD_SIMPLE_DO_INSIDE);
RNA_def_property_ui_text(prop, "Collapse Edges", "Remove doubles on the surface of the mesh by collapsing existing edges");
RNA_def_property_update(prop, 0, "rna_Modifier_update");
RNA_define_lib_overridable(false); RNA_define_lib_overridable(false);
} }
Context not available.