Differential D9121 Diff 29627 source/blender/editors/animation/anim_channels_defines.c

Changeset View

Standalone View

source/blender/editors/animation/anim_channels_defines.c

Context not available.
	* and wouldn't be able to auto-keyframe.	* and wouldn't be able to auto-keyframe.
	* - Slider should start before the toggles (if they're visible)	* - Slider should start before the toggles (if they're visible)
	* to keep a clean line down the side.	* to keep a clean line down the side.
		* - T67776: Sliders are always drawn in Shapekey mode now. Prior to this
		* the SACTION_SLIDERS flag would be set when changing into Shapekey mode.
	*/	*/
	if ((draw_sliders) &&	if (draw_sliders
		sybrenUnsubmitted Done Inline Actions Although I agree with the removal of the superfluous parentheses, it's better to not do that in this patch. Cleanups, refactors, and other non-functional changes have to be committed separately from functional changes. Generally such cleanups are much easier to approve & land in master, and when that's done, the patch with functional changes will be smaller and thus easier to review as well. sybren: Although I agree with the removal of the superfluous parentheses, it's better to not do that in…
	ELEM(ale->type, ANIMTYPE_FCURVE, ANIMTYPE_NLACURVE, ANIMTYPE_SHAPEKEY, ANIMTYPE_GPLAYER)) {	&& ELEM(ale->type, ANIMTYPE_FCURVE, ANIMTYPE_NLACURVE, ANIMTYPE_SHAPEKEY, ANIMTYPE_GPLAYER)
		\|\| ale->type == ANIMTYPE_SHAPEKEY) {
		sybrenUnsubmitted Done Inline Actions Combining `&&` and `\|\|` is ambiguous, and requires parentheses. sybren: Combining `&&` and `\|\|` is ambiguous, and requires parentheses.
	/* adjust offset */	/* adjust offset */
	/* TODO: make slider width dynamic,	/* TODO: make slider width dynamic,
	* so that they can be easier to use when the view is wide enough. */	* so that they can be easier to use when the view is wide enough. */
Context not available.