Page MenuHome
Differential D10075 Diff 32615 source/blender/depsgraph/intern/builder/deg_builder_nodes.h

Changeset View

Standalone View

View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.h

Show First 20 Lines • Show All 146 Lines • ▼ Show 20 Lines OperationNode *find_operation_node(ID *id,
const char *name = "", const char *name = "",
int name_tag = -1); int name_tag = -1);
OperationNode *find_operation_node( OperationNode *find_operation_node(
ID *id, NodeType comp_type, OperationCode opcode, const char *name = "", int name_tag = -1); ID *id, NodeType comp_type, OperationCode opcode, const char *name = "", int name_tag = -1);
virtual void build_id(ID *id); virtual void build_id(ID *id);
virtual void build_generic_id(ID *id);
sybrenUnsubmitted
Not Done
Inline Actions

To me "generic" doesn't really convey "this ID type doesn't use CoW". The generic nature does become clear when the CoW'ed ID types all have their own build function, and the CoW-less ones all use the same generic one, but that did require me to dive into the build_id() function first.

I think it would be enough to just add a oneliner comment above this declaration, something like:

/* Build function for ID types that need neither their own build_xxx() function nor copy-on-write. */
sybren: To me "generic" doesn't really convey "this ID type doesn't use CoW". The generic nature does…
sergeyAuthorUnsubmitted
Done
Inline Actions

Thing is, is not really about coverage or not with CoW. The datablock can be CoW-ed, but still need to be build using build_generic_id.

I like the idea of comment /* Build function for ID types that do not need their own build_xxx() function. */.

Do you have suggestion for the name?

sergey: Thing is, is not really about coverage or not with CoW. The datablock can be CoW-ed, but still…
sybrenUnsubmitted
Not Done
Inline Actions

In that case I think the name is fine, especially with that comment in place.

sybren: In that case I think the name is fine, especially with that comment in place.
virtual void build_idproperties(IDProperty *id_property); virtual void build_idproperties(IDProperty *id_property);
virtual void build_scene_render(Scene *scene, ViewLayer *view_layer); virtual void build_scene_render(Scene *scene, ViewLayer *view_layer);
virtual void build_scene_parameters(Scene *scene); virtual void build_scene_parameters(Scene *scene);
virtual void build_scene_compositor(Scene *scene); virtual void build_scene_compositor(Scene *scene);
virtual void build_layer_collections(ListBase *lb); virtual void build_layer_collections(ListBase *lb);
virtual void build_view_layer(Scene *scene, virtual void build_view_layer(Scene *scene,
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines