Page MenuHome
Differential D7916 Diff 32951 release/scripts/startup/bl_app_templates_system/Video_Editing/__init__.py

Changeset View

Standalone View

View Options

release/scripts/startup/bl_app_templates_system/Video_Editing/__init__.py

Context not available.
space = area.spaces.active space = area.spaces.active
params = space.params params = space.params
params.use_filter_folder = True params.use_filter_folder = True
user_prefs = bpy.context.preferences
user_prefs.view.timecode_style = "SMPTE"
ISSAuthorUnsubmitted
Done
Inline Actions

This prevents user from saving his own timecode style in user preferences.

You would have to do this in load_factory_preferences_post handler as versioning change. And include userpref.blend file for sequencer.
See example in https://docs.blender.org/manual/en/latest/advanced/app_templates.html#template-scripts

Question is if this is OK to do UI wise, because none builtin template have own preferences. This can cause some confusion I think.

Also then any versioning change of preferences file would have to take sequencer preferences into account, which is not very nice.

So unless anybody has idea how to do this nicely, I disagree with this change.

ISS: This prevents user from saving his own timecode style in user preferences. You would have to…
campbellbartonUnsubmitted
Done
Inline Actions

Avoid using the context in versioning code, loop over bpy.data.scenes instead.

campbellbarton: Avoid using the context in versioning code, loop over `bpy.data.scenes` instead.
ISSAuthorUnsubmitted
Done
Inline Actions

bpy.data.scenes is collection of scenes you have to iterate it or access by index. I assume that iterating is preferred even if there is only 1 scene.

for scene in bpy.data.scenes:
    render = scene.render
    render.image_settings.file_format = 'FFMPEG'

    preset = "h264_in_MP4"
    filename = bpy.utils.preset_find(preset, preset_path="ffmpeg")
    if filename:
        bpy.utils.execfile(filename)
    else:
        print("Preset %r not found" % preset)

    render.ffmpeg.audio_codec = "AAC"
    render.ffmpeg.audio_bitrate = 256
ISS: `bpy.data.scenes` is collection of scenes you have to iterate it or access by index. I assume…
render = bpy.context.scene.render
ISSAuthorUnsubmitted
Done
Inline Actions

I think setting this once should be enough :)

ISS: I think setting this once should be enough :)
tintwotinUnsubmitted
Done
Inline Actions

Thanks.

tintwotin: Thanks.
render.image_settings.file_format = 'FFMPEG'
preset = "h264_in_MP4"
filename = bpy.utils.preset_find(preset, preset_path="ffmpeg")
if filename:
bpy.utils.execfile(filename)
campbellbartonUnsubmitted
Not Done
Inline Actions

This can be moved into a utility function, for now this is OK though.

campbellbarton: This can be moved into a utility function, for now this is OK though.
else:
print("Preset %r not found" % preset)
render.ffmpeg.audio_codec = "AAC"
render.ffmpeg.audio_bitrate = 256
ISSAuthorUnsubmitted
Done
Inline Actions

I have done test of influence of GOP and max B-frames value with default preset vs. proposed - Render time was pretty much same, filesize as well and seekability difference was impercievable.

So I think we should set these to preset default - GOP: 18 and max B frames to False

ISS: I have done test of influence of GOP and max B-frames value with default preset vs. proposed…
EAWUnsubmitted
Done
Inline Actions

Just as an FYI: According to this paper from 2010, GOP size influences video quality when viewing video over a wireless network. Higher GOP sizes are better when there is more traffic and therefore packet loss. The higher the GOP size, the lower the chance that consecutive I-frames packets are lost. Testing video quality on a local machine won't show this. =)

Youtube recommends GOP size to be "half the frame rate" and "2 consecutive B frames."

EAW: Just as an FYI: According to [this paper from 2010](https://www.researchgate.
def register(): def register():
Context not available.