Changeset View
Changeset View
Standalone View
Standalone View
source/blender/sequencer/SEQ_sequencer.h
| Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines | |||||
| void SEQ_tool_settings_free(struct SequencerToolSettings *tool_settings); | void SEQ_tool_settings_free(struct SequencerToolSettings *tool_settings); | ||||
| eSeqImageFitMethod SEQ_tool_settings_fit_method_get(struct Scene *scene); | eSeqImageFitMethod SEQ_tool_settings_fit_method_get(struct Scene *scene); | ||||
| void SEQ_tool_settings_fit_method_set(struct Scene *scene, eSeqImageFitMethod fit_method); | void SEQ_tool_settings_fit_method_set(struct Scene *scene, eSeqImageFitMethod fit_method); | ||||
| struct SequencerToolSettings *SEQ_tool_settings_copy(struct SequencerToolSettings *tool_settings); | struct SequencerToolSettings *SEQ_tool_settings_copy(struct SequencerToolSettings *tool_settings); | ||||
| struct Editing *SEQ_editing_get(struct Scene *scene, bool alloc); | struct Editing *SEQ_editing_get(struct Scene *scene, bool alloc); | ||||
| struct Editing *SEQ_editing_ensure(struct Scene *scene); | struct Editing *SEQ_editing_ensure(struct Scene *scene); | ||||
| void SEQ_editing_free(struct Scene *scene, const bool do_id_user); | void SEQ_editing_free(struct Scene *scene, const bool do_id_user); | ||||
| struct ListBase *SEQ_active_seqbase_get(const struct Editing *ed); | struct ListBase *SEQ_active_seqbase_get(const struct Editing *ed); | ||||
| void SEQ_seqbase_active_set(struct Editing *ed, struct ListBase *seqbase); | |||||
campbellbarton: This reads like a function that sets active sequence (at least at a glance).
Where this is… | |||||
Done Inline ActionsI have never read this guideline this way, but I can see how object could be any C struct and property could be it's member. I would rather do SEQ_seqbase_active_set even though it technically operates on Editing. ISS: I have never read this guideline this way, but I can see how `object` could be any C struct and… | |||||
| struct Sequence *SEQ_sequence_alloc(ListBase *lb, int timeline_frame, int machine, int type); | struct Sequence *SEQ_sequence_alloc(ListBase *lb, int timeline_frame, int machine, int type); | ||||
| void SEQ_sequence_free(struct Scene *scene, struct Sequence *seq, const bool do_clean_animdata); | void SEQ_sequence_free(struct Scene *scene, struct Sequence *seq, const bool do_clean_animdata); | ||||
| struct MetaStack *SEQ_meta_stack_alloc(struct Editing *ed, struct Sequence *seq_meta); | |||||
| struct MetaStack *SEQ_meta_stack_active_get(const struct Editing *ed); | |||||
Done Inline ActionsWord ordering isn't following https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Naming SEQ_active_meta_stack_get could be SEQ_meta_stack_active_get. Which matches SEQ_editing_seqbase_active_set campbellbarton: Word ordering isn't following https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Naming… | |||||
| void SEQ_meta_stack_free(struct Editing *ed, struct MetaStack *ms); | |||||
| void SEQ_offset_animdata(struct Scene *scene, struct Sequence *seq, int ofs); | void SEQ_offset_animdata(struct Scene *scene, struct Sequence *seq, int ofs); | ||||
| void SEQ_dupe_animdata(struct Scene *scene, const char *name_src, const char *name_dst); | void SEQ_dupe_animdata(struct Scene *scene, const char *name_src, const char *name_dst); | ||||
| struct Sequence *SEQ_sequence_dupli_recursive(const struct Scene *scene_src, | struct Sequence *SEQ_sequence_dupli_recursive(const struct Scene *scene_src, | ||||
| struct Scene *scene_dst, | struct Scene *scene_dst, | ||||
| struct ListBase *new_seq_list, | struct ListBase *new_seq_list, | ||||
| struct Sequence *seq, | struct Sequence *seq, | ||||
| int dupe_flag); | int dupe_flag); | ||||
| void SEQ_sequence_base_dupli_recursive(const struct Scene *scene_src, | void SEQ_sequence_base_dupli_recursive(const struct Scene *scene_src, | ||||
| Show All 9 Lines | |||||
This reads like a function that sets active sequence (at least at a glance).
Where this is really a very specialized function which is not used often.
This could be called SEQ_editing_seqbase_active_set or SEQ_editing_seqbase_set ?