Page MenuHome
Differential D817 Diff 2694 source/blender/bmesh/tools/bmesh_decimate_dissolve.c

Changeset View

Standalone View

View Options

source/blender/bmesh/tools/bmesh_decimate_dissolve.c

Context not available.
BMVert **vinput_arr = BM_iter_as_arrayN(bm, BM_VERTS_OF_MESH, NULL, &vinput_len, NULL, 0); BMVert **vinput_arr = BM_iter_as_arrayN(bm, BM_VERTS_OF_MESH, NULL, &vinput_len, NULL, 0);
BMEdge **einput_arr = BM_iter_as_arrayN(bm, BM_EDGES_OF_MESH, NULL, &einput_len, NULL, 0); BMEdge **einput_arr = BM_iter_as_arrayN(bm, BM_EDGES_OF_MESH, NULL, &einput_len, NULL, 0);
/* caused crashes in conjunction with fracture modifier when using limited dissolve operator from there,
* so added a sanity check here as crash prevention */
if (vinput_arr == NULL || einput_arr == NULL)
sergeyUnsubmitted
Not Done
Inline Actions

I think it should not be needed. Callee function is to be responsible to pass all the data. You can add BLI_assert() here, but not a silent failure.

sergey: I think it should not be needed. Callee function is to be responsible to pass all the data. You…
return;
BM_mesh_decimate_dissolve_ex(bm, angle_limit, do_dissolve_boundaries, BM_mesh_decimate_dissolve_ex(bm, angle_limit, do_dissolve_boundaries,
delimit, delimit,
Context not available.