Page MenuHome
Differential D829 Diff 2725 source/blender/editors/interface/interface_widgets.c

Changeset View

Standalone View

View Options

source/blender/editors/interface/interface_widgets.c

Show First 20 Lines • Show All 749 Lines • ▼ Show 20 Lines for (j = 0; j < WIDGET_AA_JITTER; j++) {
/* outline */ /* outline */
glColor4ubv(tcol); glColor4ubv(tcol);
glVertexPointer(2, GL_FLOAT, 0, quad_strip); glVertexPointer(2, GL_FLOAT, 0, quad_strip);
glDrawArrays(GL_QUAD_STRIP, 0, wtb->totvert * 2 + 2); glDrawArrays(GL_QUAD_STRIP, 0, wtb->totvert * 2 + 2);
/* emboss bottom shadow */ /* emboss bottom shadow */
unsigned char emboss[4];
pablovazquezUnsubmitted
Not Done
Inline Actions

I'm no dev, but I get a build error because of this. (ISO C90 forbids mixed declarations and code)

Declarations should be done at the beginning of the block (line 749, where the loop starts).

pablovazquez: I'm no dev, but I get a build error because of this. (ISO C90 forbids mixed declarations and…
UI_GetThemeColor4ubv(TH_EMBOSS, emboss);
if (wtb->emboss) { if (wtb->emboss) {
campbellbartonUnsubmitted
Not Done
Inline Actions

this can be handled a little smarter...

if (wtb->emboss) {
    UI_GetThemeColor4ubv(TH_EMBOSS, emboss);
    if (emboss[3]) {
        .....glColor4ubv. glVertexPointer, glDrawArrays... etc
    }
campbellbarton: this can be handled a little smarter... if (wtb->emboss) { UI_GetThemeColor4ubv…
glColor4f(1.0f, 1.0f, 1.0f, 0.02f); glColor4ubv(emboss);
glVertexPointer(2, GL_FLOAT, 0, quad_strip_emboss); glVertexPointer(2, GL_FLOAT, 0, quad_strip_emboss);
glDrawArrays(GL_QUAD_STRIP, 0, wtb->halfwayvert * 2); glDrawArrays(GL_QUAD_STRIP, 0, wtb->halfwayvert * 2);
} }
glTranslatef(-jit[j][0], -jit[j][1], 0.0f); glTranslatef(-jit[j][0], -jit[j][1], 0.0f);
} }
▲ Show 20 Lines • Show All 3,280 Lines • Show Last 20 Lines