Page MenuHome
Differential D10681 Diff 35021 source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc

Changeset View

Standalone View

View Options

source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc

Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines case CD_PROP_BOOL: {
})); }));
break; break;
} }
default: default:
break; break;
} }
} }
static GeometrySet get_display_geometry_set(Object *object_eval) static GeometrySet get_display_geometry_set(Object *object_eval,
const GeometryComponentType used_component_type)
{ {
GeometrySet geometry_set; GeometrySet geometry_set;
if (object_eval->mode == OB_MODE_EDIT) { if (used_component_type == GEO_COMPONENT_TYPE_MESH && object_eval->mode == OB_MODE_EDIT) {
Mesh *mesh = BKE_modifier_get_evaluated_mesh_from_evaluated_object(object_eval, false); Mesh *mesh = BKE_modifier_get_evaluated_mesh_from_evaluated_object(object_eval, false);
if (mesh == nullptr) { if (mesh == nullptr) {
return geometry_set; return geometry_set;
} }
BKE_mesh_wrapper_ensure_mdata(mesh); BKE_mesh_wrapper_ensure_mdata(mesh);
MeshComponent &mesh_component = geometry_set.get_component_for_write<MeshComponent>(); MeshComponent &mesh_component = geometry_set.get_component_for_write<MeshComponent>();
mesh_component.replace(mesh, GeometryOwnershipType::ReadOnly); mesh_component.replace(mesh, GeometryOwnershipType::ReadOnly);
mesh_component.copy_vertex_group_names_from_object(*object_eval); mesh_component.copy_vertex_group_names_from_object(*object_eval);
} }
else { else {
if (object_eval->runtime.geometry_set_eval != nullptr) { if (object_eval->runtime.geometry_set_eval != nullptr) {
/* This does not copy the geometry data itself. */ /* This does not copy the geometry data itself. */
geometry_set = *object_eval->runtime.geometry_set_eval; geometry_set = *object_eval->runtime.geometry_set_eval;
} }
} }
return geometry_set; return geometry_set;
} }
static Span<int64_t> filter_visible_mesh_vertex_rows(const bContext *C, using IsVertexSelectedFn = FunctionRef<bool(int vertex_index)>;
static void get_selected_vertex_indices(const Mesh &mesh,
const IsVertexSelectedFn is_vertex_selected_fn,
Vector<int64_t> &r_vertex_indices)
{
for (const int i : IndexRange(mesh.totvert)) {
if (is_vertex_selected_fn(i)) {
r_vertex_indices.append(i);
}
}
}
static void get_selected_corner_indices(const Mesh &mesh,
const IsVertexSelectedFn is_vertex_selected_fn,
Vector<int64_t> &r_corner_indices)
{
for (const int i : IndexRange(mesh.totloop)) {
const MLoop &loop = mesh.mloop[i];
if (is_vertex_selected_fn(loop.v)) {
r_corner_indices.append(i);
}
}
}
static void get_selected_polygon_indices(const Mesh &mesh,
const IsVertexSelectedFn is_vertex_selected_fn,
Vector<int64_t> &r_polygon_indices)
{
for (const int poly_index : IndexRange(mesh.totpoly)) {
const MPoly &poly = mesh.mpoly[poly_index];
bool is_selected = true;
for (const int loop_index : IndexRange(poly.loopstart, poly.totloop)) {
const MLoop &loop = mesh.mloop[loop_index];
if (!is_vertex_selected_fn(loop.v)) {
is_selected = false;
break;
}
}
if (is_selected) {
r_polygon_indices.append(poly_index);
}
}
}
static void get_selected_edge_indices(const Mesh &mesh,
const IsVertexSelectedFn is_vertex_selected_fn,
Vector<int64_t> &r_edge_indices)
{
for (const int i : IndexRange(mesh.totedge)) {
const MEdge &edge = mesh.medge[i];
if (is_vertex_selected_fn(edge.v1) && is_vertex_selected_fn(edge.v2)) {
r_edge_indices.append(i);
}
}
}
static void get_selected_indices_on_domain(const Mesh &mesh,
const AttributeDomain domain,
const IsVertexSelectedFn is_vertex_selected_fn,
Vector<int64_t> &r_indices)
{
switch (domain) {
case ATTR_DOMAIN_POINT:
return get_selected_vertex_indices(mesh, is_vertex_selected_fn, r_indices);
case ATTR_DOMAIN_POLYGON:
return get_selected_polygon_indices(mesh, is_vertex_selected_fn, r_indices);
case ATTR_DOMAIN_CORNER:
return get_selected_corner_indices(mesh, is_vertex_selected_fn, r_indices);
case ATTR_DOMAIN_EDGE:
return get_selected_edge_indices(mesh, is_vertex_selected_fn, r_indices);
default:
return;
}
}
static Span<int64_t> filter_mesh_elements_by_selection(const bContext *C,
Object *object_eval, Object *object_eval,
const MeshComponent *component, const MeshComponent *component,
const AttributeDomain domain,
ResourceCollector &resources) ResourceCollector &resources)
{ {
SpaceSpreadsheet *sspreadsheet = CTX_wm_space_spreadsheet(C); SpaceSpreadsheet *sspreadsheet = CTX_wm_space_spreadsheet(C);
const bool show_only_selected = sspreadsheet->filter_flag & SPREADSHEET_FILTER_SELECTED_ONLY; const bool show_only_selected = sspreadsheet->filter_flag & SPREADSHEET_FILTER_SELECTED_ONLY;
if (object_eval->mode == OB_MODE_EDIT && show_only_selected) { if (object_eval->mode == OB_MODE_EDIT && show_only_selected) {
Object *object_orig = DEG_get_original_object(object_eval); Object *object_orig = DEG_get_original_object(object_eval);
Vector<int64_t> &visible_rows = resources.construct<Vector<int64_t>>("visible rows"); Vector<int64_t> &visible_rows = resources.construct<Vector<int64_t>>("visible rows");
const Mesh *mesh_eval = component->get_for_read(); const Mesh *mesh_eval = component->get_for_read();
Mesh *mesh_orig = (Mesh *)object_orig->data; Mesh *mesh_orig = (Mesh *)object_orig->data;
BMesh *bm = mesh_orig->edit_mesh->bm; BMesh *bm = mesh_orig->edit_mesh->bm;
BM_mesh_elem_table_ensure(bm, BM_VERT); BM_mesh_elem_table_ensure(bm, BM_VERT);
int *orig_indices = (int *)CustomData_get_layer(&mesh_eval->vdata, CD_ORIGINDEX); int *orig_indices = (int *)CustomData_get_layer(&mesh_eval->vdata, CD_ORIGINDEX);
if (orig_indices != nullptr) { if (orig_indices != nullptr) {
/* Use CD_ORIGINDEX layer if it exists. */ /* Use CD_ORIGINDEX layer if it exists. */
for (const int i_eval : IndexRange(mesh_eval->totvert)) { auto is_vertex_selected = [&](int vertex_index) -> bool {
const int i_orig = orig_indices[i_eval]; const int i_orig = orig_indices[vertex_index];
if (i_orig >= 0 && i_orig < bm->totvert) { if (i_orig < 0) {
BMVert *vert = bm->vtable[i_orig]; return false;
if (BM_elem_flag_test(vert, BM_ELEM_SELECT)) {
visible_rows.append(i_eval);
}
} }
if (i_orig >= bm->totvert) {
return false;
} }
BMVert *vert = bm->vtable[i_orig];
return BM_elem_flag_test(vert, BM_ELEM_SELECT);
};
get_selected_indices_on_domain(*mesh_eval, domain, is_vertex_selected, visible_rows);
} }
else if (mesh_eval->totvert == bm->totvert) { else if (mesh_eval->totvert == bm->totvert) {
/* Use a simple heuristic to match original vertices to evaluated ones. */ /* Use a simple heuristic to match original vertices to evaluated ones. */
for (const int i : IndexRange(mesh_eval->totvert)) { auto is_vertex_selected = [&](int vertex_index) -> bool {
BMVert *vert = bm->vtable[i]; BMVert *vert = bm->vtable[vertex_index];
if (BM_elem_flag_test(vert, BM_ELEM_SELECT)) { return BM_elem_flag_test(vert, BM_ELEM_SELECT);
visible_rows.append(i); };
} get_selected_indices_on_domain(*mesh_eval, domain, is_vertex_selected, visible_rows);
}
} }
/* This is safe, because the vector lives in the resource collector. */ /* This is safe, because the vector lives in the resource collector. */
return visible_rows.as_span(); return visible_rows.as_span();
} }
/* No filter is used. */ /* No filter is used. */
const int domain_size = component->attribute_domain_size(ATTR_DOMAIN_POINT); const int domain_size = component->attribute_domain_size(domain);
return IndexRange(domain_size).as_span(); return IndexRange(domain_size).as_span();
} }
std::unique_ptr<SpreadsheetDrawer> spreadsheet_drawer_from_geometry_attributes(const bContext *C, std::unique_ptr<SpreadsheetDrawer> spreadsheet_drawer_from_geometry_attributes(const bContext *C,
Object *object_eval) Object *object_eval)
{ {
SpaceSpreadsheet *sspreadsheet = CTX_wm_space_spreadsheet(C);
const AttributeDomain domain = (AttributeDomain)sspreadsheet->attribute_domain;
const GeometryComponentType component_type = (GeometryComponentType)
sspreadsheet->geometry_component_type;
/* Create a resource collector that owns stuff that needs to live until drawing is done. */ /* Create a resource collector that owns stuff that needs to live until drawing is done. */
std::unique_ptr<ResourceCollector> resources = std::make_unique<ResourceCollector>(); std::unique_ptr<ResourceCollector> resources = std::make_unique<ResourceCollector>();
GeometrySet &geometry_set = resources->add_value(get_display_geometry_set(object_eval), GeometrySet &geometry_set = resources->add_value(
"geometry set"); get_display_geometry_set(object_eval, component_type), "geometry set");
const AttributeDomain domain = ATTR_DOMAIN_POINT;
const GeometryComponentType component_type = GEO_COMPONENT_TYPE_MESH;
const GeometryComponent *component = geometry_set.get_component_for_read(component_type); const GeometryComponent *component = geometry_set.get_component_for_read(component_type);
if (component == nullptr) { if (component == nullptr) {
return {}; return {};
} }
if (!component->attribute_domain_supported(domain)) {
return {};
}
Vector<std::string> attribute_names = get_sorted_attribute_names_to_display(*component, domain); Vector<std::string> attribute_names = get_sorted_attribute_names_to_display(*component, domain);
Vector<std::unique_ptr<AttributeColumn>> columns; Vector<std::unique_ptr<AttributeColumn>> columns;
for (StringRefNull attribute_name : attribute_names) { for (StringRefNull attribute_name : attribute_names) {
ReadAttributePtr attribute_ptr = component->attribute_try_get_for_read(attribute_name); ReadAttributePtr attribute_ptr = component->attribute_try_get_for_read(attribute_name);
ReadAttribute &attribute = *attribute_ptr; ReadAttribute &attribute = *attribute_ptr;
resources->add(std::move(attribute_ptr), "attribute"); resources->add(std::move(attribute_ptr), "attribute");
add_columns_for_attribute(&attribute, attribute_name, columns); add_columns_for_attribute(&attribute, attribute_name, columns);
} }
/* The filter below only works for mesh vertices currently. */ /* The filter below only works for mesh vertices currently. */
BLI_assert(domain == ATTR_DOMAIN_POINT && component_type == GEO_COMPONENT_TYPE_MESH); Span<int64_t> visible_rows;
HooglyBooglyUnsubmitted
Not Done
Inline Actions

I would expect this to be an IndexMask, does that make sense? A separate cleanup though, possibly.

HooglyBoogly: I would expect this to be an `IndexMask`, does that make sense? A separate cleanup though…
JacquesLuckeAuthorUnsubmitted
Done
Inline Actions

Right now it could be an IndexMask. However, as soon as sorting is supported, this does not work anymore. An IndexMask has the invariant that it is always sorted (because that allows some optimizations).

JacquesLucke: Right now it could be an `IndexMask`. However, as soon as sorting is supported, this does not…
HooglyBooglyUnsubmitted
Done
Inline Actions

Ah right, forgot about that. Thanks.

HooglyBoogly: Ah right, forgot about that. Thanks.
Span<int64_t> visible_rows = filter_visible_mesh_vertex_rows( if (component_type == GEO_COMPONENT_TYPE_MESH) {
C, object_eval, static_cast<const MeshComponent *>(component), *resources); visible_rows = filter_mesh_elements_by_selection(
C, object_eval, static_cast<const MeshComponent *>(component), domain, *resources);
}
else {
visible_rows = IndexRange(component->attribute_domain_size(domain)).as_span();
}
const int domain_size = component->attribute_domain_size(domain); const int domain_size = component->attribute_domain_size(domain);
return std::make_unique<GeometryAttributeSpreadsheetDrawer>( return std::make_unique<GeometryAttributeSpreadsheetDrawer>(
std::move(resources), std::move(columns), visible_rows, domain_size); std::move(resources), std::move(columns), visible_rows, domain_size);
} }
} // namespace blender::ed::spreadsheet } // namespace blender::ed::spreadsheet