Changeset View
Changeset View
Standalone View
Standalone View
source/blender/nodes/geometry/nodes/node_geo_attribute_remove.cc
- This file was added.
| /* | |||||
| * This program is free software; you can redistribute it and/or | |||||
| * modify it under the terms of the GNU General Public License | |||||
| * as published by the Free Software Foundation; either version 2 | |||||
| * of the License, or (at your option) any later version. | |||||
| * | |||||
| * This program is distributed in the hope that it will be useful, | |||||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |||||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||||
| * GNU General Public License for more details. | |||||
| * | |||||
| * You should have received a copy of the GNU General Public License | |||||
| * along with this program; if not, write to the Free Software Foundation, | |||||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||||
| */ | |||||
| #include "BKE_material.h" | |||||
| #include "DNA_material_types.h" | |||||
| #include "UI_interface.h" | |||||
| #include "UI_resources.h" | |||||
HooglyBoogly: Unused includes | |||||
| #include "node_geometry_util.hh" | |||||
| static bNodeSocketTemplate geo_node_attribute_remove_in[] = { | |||||
| {SOCK_GEOMETRY, N_("Geometry")}, | |||||
| {SOCK_STRING, N_("Attribute")}, | |||||
| {-1, ""}, | |||||
| }; | |||||
| static bNodeSocketTemplate geo_node_attribute_remove_out[] = { | |||||
| {SOCK_GEOMETRY, N_("Geometry")}, | |||||
| {-1, ""}, | |||||
| }; | |||||
| namespace blender::nodes { | |||||
| static void remove_attribute(GeometryComponent &component, const GeoNodeExecParams ¶ms) | |||||
| { | |||||
| const std::string attribute_name = params.get_input<std::string>("Attribute"); | |||||
| if (attribute_name.empty()) { | |||||
| params.error_message_add(NodeWarningType::Error,"Supply the name of the attribute to delete"); | |||||
HooglyBooglyUnsubmitted Done Inline ActionsThis is a common, expected situation, no need to add an error in this case. HooglyBoogly: This is a common, expected situation, no need to add an error in this case. | |||||
| return; | |||||
| } | |||||
| bool is_attribute_deleted = component.attribute_try_delete(attribute_name); | |||||
| if (!is_attribute_deleted) { | |||||
HooglyBooglyUnsubmitted Done Inline ActionsPersonally I would skip assigning the temp variable here and just put the operation in the if statement. HooglyBoogly: Personally I would skip assigning the temp variable here and just put the operation in the if… | |||||
| params.error_message_add(NodeWarningType::Error,"Cannot delete attribute"); | |||||
HooglyBooglyUnsubmitted Done Inline ActionsI'd like to be explicit and add the name of the attribute here, like the other related error messages HooglyBoogly: I'd like to be explicit and add the name of the attribute here, like the other related error… | |||||
| } | |||||
| } | |||||
| static void geo_node_attribute_remove_exec(GeoNodeExecParams params) | |||||
| { | |||||
| GeometrySet geometry_set = params.extract_input<GeometrySet>("Geometry"); | |||||
| geometry_set = geometry_set_realize_instances(geometry_set); | |||||
| if (geometry_set.has<MeshComponent>()) { | |||||
| remove_attribute(geometry_set.get_component_for_write<MeshComponent>(), params); | |||||
| } | |||||
| if (geometry_set.has<PointCloudComponent>()) { | |||||
| remove_attribute(geometry_set.get_component_for_write<PointCloudComponent>(), params); | |||||
| } | |||||
| params.set_output("Geometry", geometry_set); | |||||
| } | |||||
| } | |||||
| void register_node_type_geo_attribute_remove() | |||||
| { | |||||
| static bNodeType ntype; | |||||
| geo_node_type_base(&ntype, GEO_NODE_ATTRIBUTE_REMOVE, "Attribute Remove", NODE_CLASS_ATTRIBUTE, 0); | |||||
| node_type_socket_templates(&ntype, geo_node_attribute_remove_in, geo_node_attribute_remove_out); | |||||
| ntype.geometry_node_execute = blender::nodes::geo_node_attribute_remove_exec; | |||||
| nodeRegisterType(&ntype); | |||||
| } | |||||
Unused includes