Page MenuHome
Differential D10719 Diff 35550 intern/guardedalloc/tests/guardedalloc_overflow_test.cc

Changeset View

Standalone View

View Options

intern/guardedalloc/tests/guardedalloc_overflow_test.cc

/* Apache License, Version 2.0 */ /* Apache License, Version 2.0 */
#include "testing/testing.h" #include "testing/testing.h"
#include "MEM_guardedalloc.h" #include "MEM_guardedalloc.h"
#include "guardedalloc_test_base.h" #include "guardedalloc_test_base.h"
/* We expect to abort on integer overflow, to prevent possible exploits. */ #include "mallocn_intern.h"
#if defined(__GNUC__) && !defined(__clang__) /* We expect to abort on integer overflow, to prevent possible exploits. */
/* Disable since it's the purpose of this test. */
# pragma GCC diagnostic ignored "-Walloc-size-larger-than="
#endif
namespace { namespace {
void safe_multiply_pass(const size_t len, const size_t size)
{
size_t total_size = 0;
const bool ok = MEM_size_safe_multiply(len, size, &total_size);
EXPECT_TRUE(ok);
EXPECT_GT(total_size, 0);
}
/**
* `MEM_size_safe_multiply` is expected to fail due to Integer Overflow.
*/
void safe_multiply_fail(const size_t len, const size_t size)
{
size_t total_size = 0;
const bool ok = MEM_size_safe_multiply(len, size, &total_size);
EXPECT_FALSE(ok);
EXPECT_GT(total_size, 0);
}
} // namespace
TEST(AllocatorTest, MultiplyIntegerOverflow)
{
safe_multiply_pass(1, SIZE_MAX);
safe_multiply_pass(SIZE_MAX, 1);
safe_multiply_pass(SIZE_MAX / 2, 2);
safe_multiply_pass(SIZE_MAX / 1234567, 1234567);
safe_multiply_fail(SIZE_MAX, 2);
safe_multiply_fail(7, SIZE_MAX);
safe_multiply_fail(SIZE_MAX, 12345567);
safe_multiply_fail(SIZE_MAX, SIZE_MAX);
}
#ifndef __APPLE__
/* The death tests use `fork()` which when used with Address Sanitizer on
* macOS, causes test to exit with `SIGILL`. That causes a false positive
* test failure. So disable `EXPECT_EXIT` tests on macOS.
*/
namespace {
void MallocArray(size_t len, size_t size) void MallocArray(size_t len, size_t size)
{ {
void *mem = MEM_malloc_arrayN(len, size, "MallocArray"); void *mem = MEM_malloc_arrayN(len, size, "MallocArray");
if (mem) { if (mem) {
MEM_freeN(mem); MEM_freeN(mem);
} }
} }
void CallocArray(size_t len, size_t size) void CallocArray(size_t len, size_t size)
sergeyUnsubmitted
Not Done
Inline Actions

total_size is size_t, so using boolean-typed EXPECT_TRUE seems meaningless to me.
Either explicitly check for EXPECT_GT(total_size, 0) or check for an exact value with EXPECT_EQ().

sergey: `total_size` is `size_t`, so using boolean-typed `EXPECT_TRUE` seems meaningless to me. Either…
{ {
void *mem = MEM_calloc_arrayN(len, size, "CallocArray"); void *mem = MEM_calloc_arrayN(len, size, "CallocArray");
if (mem) { if (mem) {
MEM_freeN(mem); MEM_freeN(mem);
} }
} }
} // namespace } // namespace
TEST_F(LockFreeAllocatorTest, LockfreeIntegerOverflow) TEST_F(LockFreeAllocatorTest, LockfreeIntegerOverflow)
{ {
MallocArray(1, SIZE_MAX);
CallocArray(SIZE_MAX, 1);
MallocArray(SIZE_MAX / 2, 2);
CallocArray(SIZE_MAX / 1234567, 1234567);
EXPECT_EXIT(MallocArray(SIZE_MAX, 2), ABORT_PREDICATE, ""); EXPECT_EXIT(MallocArray(SIZE_MAX, 2), ABORT_PREDICATE, "");
EXPECT_EXIT(CallocArray(7, SIZE_MAX), ABORT_PREDICATE, ""); EXPECT_EXIT(CallocArray(7, SIZE_MAX), ABORT_PREDICATE, "");
EXPECT_EXIT(MallocArray(SIZE_MAX, 12345567), ABORT_PREDICATE, ""); EXPECT_EXIT(MallocArray(SIZE_MAX, 12345567), ABORT_PREDICATE, "");
EXPECT_EXIT(CallocArray(SIZE_MAX, SIZE_MAX), ABORT_PREDICATE, ""); EXPECT_EXIT(CallocArray(SIZE_MAX, SIZE_MAX), ABORT_PREDICATE, "");
} }
TEST_F(GuardedAllocatorTest, GuardedIntegerOverflow) TEST_F(GuardedAllocatorTest, GuardedIntegerOverflow)
{ {
MallocArray(1, SIZE_MAX);
CallocArray(SIZE_MAX, 1);
MallocArray(SIZE_MAX / 2, 2);
CallocArray(SIZE_MAX / 1234567, 1234567);
EXPECT_EXIT(MallocArray(SIZE_MAX, 2), ABORT_PREDICATE, ""); EXPECT_EXIT(MallocArray(SIZE_MAX, 2), ABORT_PREDICATE, "");
EXPECT_EXIT(CallocArray(7, SIZE_MAX), ABORT_PREDICATE, ""); EXPECT_EXIT(CallocArray(7, SIZE_MAX), ABORT_PREDICATE, "");
EXPECT_EXIT(MallocArray(SIZE_MAX, 12345567), ABORT_PREDICATE, ""); EXPECT_EXIT(MallocArray(SIZE_MAX, 12345567), ABORT_PREDICATE, "");
EXPECT_EXIT(CallocArray(SIZE_MAX, SIZE_MAX), ABORT_PREDICATE, ""); EXPECT_EXIT(CallocArray(SIZE_MAX, SIZE_MAX), ABORT_PREDICATE, "");
} }
#endif