Differential D10901 Diff 35903 source/blender/makesdna/DNA_space_types.h

Changeset View

Standalone View

source/blender/makesdna/DNA_space_types.h

	Show First 20 Lines • Show All 1,845 Lines • ▼ Show 20 Lines
	} SpaceStatusBar;			} SpaceStatusBar;

	/** \} */			/** \} */

	/* -------------------------------------------------------------------- */			/* -------------------------------------------------------------------- */
	/** \name Spreadsheet			/** \name Spreadsheet
	* \{ */			* \{ */

				typedef struct SpreadsheetColumnID {
				char *name;
				int index;
				char _pad[4];
				} SpreadsheetColumnID;

				typedef struct SpreadsheetColumn {
				struct SpreadsheetColumn *next;
				struct SpreadsheetColumn *prev;
				HooglyBooglyUnsubmitted Not Done Inline Actions Picky: I get the temptation to put these on two lines, IMO the consistency of using one line is nice though, and it helps to allow ignoring it as "the ListBase part" HooglyBoogly: Picky: I get the temptation to put these on two lines, IMO the consistency of using one line is…
				JacquesLuckeAuthorUnsubmitted Done Inline Actions I honestly didn't even know there was a convention for this (looks like I don't add these listbase structures often ^^). Following the convention is fine. JacquesLucke: I honestly didn't even know there was a convention for this (looks like I don't add these…
				SpreadsheetColumnID *id;
				HooglyBooglyUnsubmitted Not Done Inline Actions Here I'd like to see a brief comment describing why `id` is allocated separately. i.e. why not just put it directly in the `SpreadsheetColumn`? HooglyBoogly: Here I'd like to see a brief comment describing why `id` is allocated separately. i.e. why not…
				JacquesLuckeAuthorUnsubmitted Done Inline Actions The reason originally was that we might want to "subclass" `SpreadsheetColumnID` if different data sources need different kinds of id. We could just put all id information in the `SpreadsheetColumnID` struct and then some fields would not be used in some cases. At some point I even added this subclass behavior (by adding a `type` enum to the struct), but I removed it from this patch to avoid making it overly complicated. JacquesLucke: The reason originally was that we might want to "subclass" `SpreadsheetColumnID` if different…
				} SpreadsheetColumn;

	typedef struct SpaceSpreadsheet {			typedef struct SpaceSpreadsheet {
	SpaceLink next, prev;			SpaceLink next, prev;
	/** Storage of regions for inactive spaces. */			/** Storage of regions for inactive spaces. */
	ListBase regionbase;			ListBase regionbase;
	char spacetype;			char spacetype;
	char link_flag;			char link_flag;
	char _pad0[6];			char _pad0[6];
	/* End 'SpaceLink' header. */			/* End 'SpaceLink' header. */

				/* List of #SpreadsheetColumn. */
				ListBase columns;

	struct ID *pinned_id;			struct ID *pinned_id;

	/* eSpaceSpreadsheet_FilterFlag. */			/* eSpaceSpreadsheet_FilterFlag. */
	uint8_t filter_flag;			uint8_t filter_flag;

	/* #GeometryComponentType. */			/* #GeometryComponentType. */
	uint8_t geometry_component_type;			uint8_t geometry_component_type;
	/* #AttributeDomain. */			/* #AttributeDomain. */
	uint8_t attribute_domain;			uint8_t attribute_domain;
	/* eSpaceSpreadsheet_ObjectContext. */			/* eSpaceSpreadsheet_ObjectContext. */
	uint8_t object_eval_state;			uint8_t object_eval_state;

	char _pad1[4];			char _pad1[4];

	SpaceSpreadsheet_Runtime *runtime;			SpaceSpreadsheet_Runtime *runtime;
	} SpaceSpreadsheet;			} SpaceSpreadsheet;

	/** \} */

	typedef enum eSpaceSpreadsheet_FilterFlag {			typedef enum eSpaceSpreadsheet_FilterFlag {
	SPREADSHEET_FILTER_SELECTED_ONLY = (1 << 0),			SPREADSHEET_FILTER_SELECTED_ONLY = (1 << 0),
	} eSpaceSpreadsheet_FilterFlag;			} eSpaceSpreadsheet_FilterFlag;

	typedef enum eSpaceSpreadsheet_ObjectEvalState {			typedef enum eSpaceSpreadsheet_ObjectEvalState {
	SPREADSHEET_OBJECT_EVAL_STATE_FINAL = 0,			SPREADSHEET_OBJECT_EVAL_STATE_FINAL = 0,
	SPREADSHEET_OBJECT_EVAL_STATE_ORIGINAL = 1,			SPREADSHEET_OBJECT_EVAL_STATE_ORIGINAL = 1,
	} eSpaceSpreadsheet_Context;			} eSpaceSpreadsheet_Context;

				/** \} */

	/* -------------------------------------------------------------------- */			/* -------------------------------------------------------------------- */
	/** \name Space Defines (eSpace_Type)			/** \name Space Defines (eSpace_Type)
	* \{ */			* \{ */

	/* space types, moved from DNA_screen_types.h */			/* space types, moved from DNA_screen_types.h */
	/* Do NOT change order, append on end. types are hardcoded needed */			/* Do NOT change order, append on end. types are hardcoded needed */
	typedef enum eSpace_Type {			typedef enum eSpace_Type {
	SPACE_EMPTY = 0,			SPACE_EMPTY = 0,
	▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines