Page MenuHome
Differential D11461 Diff 37719 source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Changeset View

Standalone View

View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Show First 20 Lines • Show All 992 Lines • ▼ Show 20 Lines
if (override_cam_is_persp) { if (override_cam_is_persp) {
sub_v3_v3v3_db(Cv, vd4, tri->v[0]->gloc); sub_v3_v3v3_db(Cv, vd4, tri->v[0]->gloc);
} }
dot_l = dot_v3v3_db(Lv, tri->gn); dot_l = dot_v3v3_db(Lv, tri->gn);
dot_r = dot_v3v3_db(Rv, tri->gn); dot_r = dot_v3v3_db(Rv, tri->gn);
dot_f = dot_v3v3_db(Cv, tri->gn); dot_f = dot_v3v3_db(Cv, tri->gn);
if (!dot_f) { /* FIXME: When we don't use `dot_f==0` here, it's theoretically possibile that _some_ faces in
zeddbUnsubmitted
Done
Inline Actions

Update the comment as discussed in blender chat.

zeddb: Update the comment as discussed in blender chat.
* perspective mode would get erroneously caught in this condition where they really are legit
* faces that would produce occlusion, but haven't encountered those yet in my test files.
*/
zeddbUnsubmitted
Done
Inline Actions

Use fabsf instead.

zeddb: Use `fabsf` instead.
NicksBestAuthorUnsubmitted
Done
Inline Actions

It's a double. I use fabs. The tolerance value needs to be FLT_EPSILON (as opposed to DBL_EPSILON) as the error introduced in the original matrix is from a float.

NicksBest: It's a double. I use `fabs`. The tolerance value needs to be `FLT_EPSILON` (as opposed to…
if (fabs(dot_f) < FLT_EPSILON) {
return false; return false;
} }
if (!a && !b && !c) { if (!a && !b && !c) {
if (!(st_l = lineart_point_triangle_relation(LFBC, FBC0, FBC1, FBC2)) && if (!(st_l = lineart_point_triangle_relation(LFBC, FBC0, FBC1, FBC2)) &&
!(st_r = lineart_point_triangle_relation(RFBC, FBC0, FBC1, FBC2))) { !(st_r = lineart_point_triangle_relation(RFBC, FBC0, FBC1, FBC2))) {
return 0; /* Intersection point is not inside triangle. */ return 0; /* Intersection point is not inside triangle. */
} }
▲ Show 20 Lines • Show All 992 Lines • Show Last 20 Lines