Differential D1082 Diff 3409 intern/opencolorio/fallback_impl.cc

Changeset View

Standalone View

intern/opencolorio/fallback_impl.cc

Context not available.
	return "sRGB";	return "sRGB";
	}	}

		void FallbackImpl::configGetDefaultLumaCoefs(OCIO_ConstConfigRcPtr * /config/, float *rgb)
		{
		/* Here we simply use the older Blender assumed primaries of
		sergeyUnsubmitted Not Done Inline Actions No need to give constants in comment, you can easily see them in the next line anyway. sergey: No need to give constants in comment, you can easily see them in the next line anyway.
		* ITU-BT.709 / sRGB, or 0.2126729 0.7151522 0.0721750. Brute
		* force stupid, but only plausible option given no color management
		* system in place. */
		sergeyUnsubmitted Not Done Inline Actions `/` should be in the new line. sergey:* `*/` should be in the new line.

		rgb[0] = 0.2126729; // ITU-BT.709 / sRGB red primary Y position
		sergeyUnsubmitted Not Done Inline Actions Do you really want to mention the standard 3 times for each of the components and mention which component you're witting into array? sergey: Do you really want to mention the standard 3 times for each of the components and mention which…
		rgb[1] = 0.7151522; // ITU-BT.709 / sRGB green primary Y position
		sergeyUnsubmitted Not Done Inline Actions Floats, not doubles. sergey: Floats, not doubles.
		sobotkaUnsubmitted Not Done Inline Actions Good spot. Will fix. sobotka: Good spot. Will fix.
		rgb[2] = 0.0721750; // ITU-BT.709 / sRGB blue primary Y position
		}

	int FallbackImpl::configGetNumLooks(OCIO_ConstConfigRcPtr * /config/)	int FallbackImpl::configGetNumLooks(OCIO_ConstConfigRcPtr * /config/)
	{	{
	return 0;	return 0;
Context not available.