Page MenuHome
Differential D1082 Diff 3458 source/blender/blenlib/BLI_math_color.h

Changeset View

Standalone View

View Options

source/blender/blenlib/BLI_math_color.h

Context not available.
unsigned int rgb_to_cpack(float r, float g, float b); unsigned int rgb_to_cpack(float r, float g, float b);
unsigned int hsv_to_cpack(float h, float s, float v); unsigned int hsv_to_cpack(float h, float s, float v);
MINLINE float rgb_to_bw(const float rgb[3]);
MINLINE float rgb_to_grayscale(const float rgb[3]);
MINLINE unsigned char rgb_to_grayscale_byte(const unsigned char rgb[3]);
MINLINE float rgb_to_luma(const float rgb[3]);
MINLINE unsigned char rgb_to_luma_byte(const unsigned char rgb[3]);
MINLINE float rgb_to_luma_y(const float rgb[3]);
campbellbartonUnsubmitted
Not Done
Inline Actions

Disagree with completely removing rgb-greyscale functions, There ware times when its reasonable to do quick color operations outside the color pipeline - When handing theme colors, onscreen/opengl colors, which checks if one on-screen color is darker than another.

campbellbarton: Disagree with completely removing rgb-greyscale functions, There ware times when its reasonable…
sobotkaUnsubmitted
Not Done
Inline Actions

The problem with this is two fold, and I can prove this with reasonable certainty:

    1. The most important issue is that if these functions remain available, developers use them. This creeps in breakages where a developer may think it is fine to do so where it is not. See how Freestyle and GLSL has borrowed the incorrect weights and propagated more problems to the color pipeline.
  2. This also assumes erroneously that all displays are sRGB and it entirely breaks correction. Even sRGB theoretical to sRGB displays need correction. This problem is exacerbated when the display isn't sRGB, but perhaps a wide gamut display as is prevalent in smaller studios.

Ultimately even the theme colors should probably be color managed. I could cite the dozens of threads on incorrect color handling in UIs that make for some rather nasty themes on wide gamut displays, or even bad color handling on browsers such as Chrome.

On a more practical level, it simply leaves vastly too many holes open for breakages. It has been shown historically that if someone is provided an API function that it will get used, and it is impossible to predict how and why a developer may be using it.

sobotka: The problem with this is two fold, and I can prove this with reasonable certainty: # The most…
/**************** Profile Transformations *****************/ /**************** Profile Transformations *****************/
void gamma_correct(float *c, float gamma); void gamma_correct(float *c, float gamma);
Context not available.