Changeset View
Standalone View
source/blender/makesrna/intern/rna_space.c
- This file is larger than 256 KB, so syntax highlighting is disabled by default.
| Show First 20 Lines • Show All 6,610 Lines • ▼ Show 20 Lines | static void rna_def_fileselect_asset_params(BlenderRNA *brna) | ||||
| static const EnumPropertyItem asset_import_type_items[] = { | static const EnumPropertyItem asset_import_type_items[] = { | ||||
| {FILE_ASSET_IMPORT_LINK, "LINK", 0, "Link", "Import the assets as linked data-block"}, | {FILE_ASSET_IMPORT_LINK, "LINK", 0, "Link", "Import the assets as linked data-block"}, | ||||
| {FILE_ASSET_IMPORT_APPEND, | {FILE_ASSET_IMPORT_APPEND, | ||||
| "APPEND", | "APPEND", | ||||
| 0, | 0, | ||||
| "Append", | "Append", | ||||
| "Import the assets as copied data-block, with no link to the original asset data-block"}, | "Import the assets as copied data-block, with no link to the original asset data-block"}, | ||||
| {FILE_ASSET_IMPORT_APPEND_REUSE, | |||||
| "APPEND_REUSE", | |||||
| 0, | |||||
| "Append (Reuse Data)", | |||||
| "Import the assets as copied data-block while avoiding multiple copies of nested, " | |||||
| "typically heavy data. For example the textures of a material asset, or the mesh of an " | |||||
| "object asset don't have to be copied every time this asset is imported. The instances of " | |||||
mont29: Second sentence is implementation detail, has nothing to do in UI tip imho. | |||||
Done Inline Actions
I think this is an implementation detail that could be removed from the tooltip. To me it's even confusing, as I would expect dragging an object in with APPEND, and then later dragging it in again with APPEND_REUSE, would still reuse the mesh data from the first append. However, this "reference ... as a way to recognize it" is not mentioned in the APPEND case, which could imply that the mesh will get appended twice. The space in the tooltip could be used for a more elaborate description of what is actually reused; I don't think that just mentioning two data types ("textures, meshes") is clear enough to have an understanding of what gets appended and what gets reused. sybren: > A reference to the original asset data-block is kept as a way to recognize it, but this is… | |||||
Done Inline ActionsChanged the tooltip. It's a bit lengthy now, which I personally think is perfectly fine if it gives a good description of the functionality that way. Also noted that the data will be shared then, which is important to understand for users. Severin: Changed the tooltip. It's a bit lengthy now, which I personally think is perfectly fine if it… | |||||
sybrenUnsubmitted Done Inline ActionsThere should be a comma after "object asset" (that makes "or the mesh of an object asset" a properly delimited sub-clause). sybren: There should be a comma after "object asset" (that makes "or the mesh of an object asset" a… | |||||
| "the asset can share the data instead"}, | |||||
sybrenUnsubmitted Not Done Inline ActionsTo clarify the writing, I wouldn't describe what can happen, but rather what happens: "The instances of the asset share the data instead". sybren: To clarify the writing, I wouldn't describe what //can happen//, but rather what //happens//… | |||||
| {0, NULL, 0, NULL, NULL}, | {0, NULL, 0, NULL, NULL}, | ||||
| }; | }; | ||||
| srna = RNA_def_struct(brna, "FileAssetSelectParams", "FileSelectParams"); | srna = RNA_def_struct(brna, "FileAssetSelectParams", "FileSelectParams"); | ||||
| RNA_def_struct_ui_text( | RNA_def_struct_ui_text( | ||||
| srna, "Asset Select Parameters", "Settings for the file selection in Asset Browser mode"); | srna, "Asset Select Parameters", "Settings for the file selection in Asset Browser mode"); | ||||
| prop = rna_def_asset_library_reference_common(srna, | prop = rna_def_asset_library_reference_common(srna, | ||||
| ▲ Show 20 Lines • Show All 1,205 Lines • Show Last 20 Lines | |||||
Second sentence is implementation detail, has nothing to do in UI tip imho.