Differential D12682 Diff 43231 source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc

Changeset View

Standalone View

source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc

This file was added.

				/*
				* This program is free software; you can redistribute it and/or
				* modify it under the terms of the GNU General Public License
				* as published by the Free Software Foundation; either version 2
				* of the License, or (at your option) any later version.
				*
				* This program is distributed in the hope that it will be useful,
				* but WITHOUT ANY WARRANTY; without even the implied warranty of
				* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
				* GNU General Public License for more details.
				*
				* You should have received a copy of the GNU General Public License
				* along with this program; if not, write to the Free Software Foundation,
				* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
				*/

				#include "BLI_task.hh"

				#include "node_geometry_util.hh"

				namespace blender::nodes {

				static void geo_node_rotate_instances_declare(NodeDeclarationBuilder &b)
				{
				b.add_input<decl::Geometry>("Geometry");
				b.add_input<decl::Vector>("Rotation").subtype(PROP_EULER).supports_field();
				b.add_input<decl::Vector>("Pivot Point").subtype(PROP_TRANSLATION).supports_field();
				b.add_input<decl::Bool>("Selection").default_value(true).hide_value().supports_field();
				b.add_input<decl::Bool>("Local Space").default_value(true).supports_field();
				b.add_output<decl::Geometry>("Geometry");
				};

				static void rotate_instances(GeoNodeExecParams &params, InstancesComponent &instances_component)
				{
				GeometryComponentFieldContext field_context{instances_component, ATTR_DOMAIN_POINT};
				const int domain_size = instances_component.instances_amount();

				fn::FieldEvaluator selection_evaluator{field_context, domain_size};
				selection_evaluator.add(params.extract_input<Field<bool>>("Selection"));
				selection_evaluator.evaluate();
				const IndexMask selection = selection_evaluator.get_evaluated_as_mask(0);

				fn::FieldEvaluator transforms_evaluator{field_context, &selection};
				transforms_evaluator.add(params.extract_input<Field<float3>>("Rotation"));
				transforms_evaluator.add(params.extract_input<Field<float3>>("Pivot Point"));
				transforms_evaluator.add(params.extract_input<Field<bool>>("Local Space"));
				transforms_evaluator.evaluate();
				const VArray<float3> &rotations = transforms_evaluator.get_evaluated<float3>(0);
				const VArray<float3> &pivots = transforms_evaluator.get_evaluated<float3>(1);
				HooglyBooglyUnsubmitted Not Done Inline Actions `extract_input` HooglyBoogly: `extract_input`
				const VArray<bool> &local_spaces = transforms_evaluator.get_evaluated<bool>(2);

				MutableSpan<float4x4> instance_transforms = instances_component.instance_transforms();

				threading::parallel_for(selection.index_range(), 512, [&](IndexRange range) {
				for (const int i_selection : range) {
				HooglyBooglyUnsubmitted Not Done Inline Actions Same comment as the other two nodes here: I don't think this is quite right, the index here is the index into the mask, not the index of the index. Here's an example from the curve reverse node: threading::parallel_for(selection.index_range(), 128, [&](IndexRange range) { for (const int i : range) { splines[selection[i]]->reverse(); } }); HooglyBoogly: Same comment as the other two nodes here: >I don't think this is quite right, the index here…
				const int i = selection[i_selection];
				const float3 pivot = pivots[i];
				float4x4 &instance_transform = instance_transforms[i];
				const float4x4 rotation_matrix = float4x4::from_loc_eul_scale(
				{0, 0, 0}, rotations[i], {1, 1, 1});

				if (local_spaces[i]) {
				instance_transform *= float4x4::from_location(pivot);
				instance_transform *= rotation_matrix;
				instance_transform *= float4x4::from_location(-pivot);
				}
				else {
				HooglyBooglyUnsubmitted Not Done Inline Actions Inverting a matrix that's built from a translation is the same thing as building the matrix from the opposite of the translation, only much more expensive. HooglyBoogly: Inverting a matrix that's built from a translation is the same thing as building the matrix…
				const float4x4 orgiginal_transform = instance_transform;
				instance_transform = float4x4::from_location(pivot);
				instance_transform *= rotation_matrix;
				instance_transform *= float4x4::from_location(-pivot);
				instance_transform *= orgiginal_transform;
				HooglyBooglyUnsubmitted Not Done Inline Actions Multiplying a matrix with the identity is the same as doing nothing at all, I think the following should work here? instance_transform = pivot_matix; ... (Though in this case there's really no need to do the assignment. HooglyBoogly: Multiplying a matrix with the identity is the same as doing nothing at all, I think the…
				}
				}
				HooglyBooglyUnsubmitted Not Done Inline Actions I think multiplying a matrix by another matrix that was just built from the same as just translating matrix directly, like with `add_v3_v3(transform.values[3]` HooglyBoogly: I think multiplying a matrix by another matrix that was just built from the same as just…
				HooglyBooglyUnsubmitted Not Done Inline Actions I think this comment is wrong actually, I didn't test this properly. Feel free to ignore it. HooglyBoogly: I think this comment is wrong actually, I didn't test this properly. Feel free to ignore it.
				});
				}

				static void geo_node_rotate_instances_exec(GeoNodeExecParams params)
				{
				GeometrySet geometry_set = params.extract_input<GeometrySet>("Geometry");
				if (geometry_set.has_instances()) {
				InstancesComponent &instances = geometry_set.get_component_for_write<InstancesComponent>();
				rotate_instances(params, instances);
				}
				params.set_output("Geometry", std::move(geometry_set));
				}

				} // namespace blender::nodes

				void register_node_type_geo_rotate_instances()
				{
				static bNodeType ntype;

				geo_node_type_base(
				&ntype, GEO_NODE_ROTATE_INSTANCES, "Rotate Instances", NODE_CLASS_GEOMETRY, 0);
				ntype.geometry_node_execute = blender::nodes::geo_node_rotate_instances_exec;
				ntype.declare = blender::nodes::geo_node_rotate_instances_declare;
				nodeRegisterType(&ntype);
				}