Page MenuHome
Differential D13043 Diff 44271 source/blender/editors/space_sequencer/sequencer_draw.c

Changeset View

Standalone View

View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Show First 20 Lines • Show All 1,383 Lines • ▼ Show 20 Linesstatic void draw_seq_strip(const bContext *C,
if ((seq->type == SEQ_TYPE_META) || if ((seq->type == SEQ_TYPE_META) ||
((seq->type == SEQ_TYPE_SCENE) && (seq->flag & SEQ_SCENE_STRIPS))) { ((seq->type == SEQ_TYPE_SCENE) && (seq->flag & SEQ_SCENE_STRIPS))) {
drawmeta_contents(scene, seq, x1, y1, x2, y2, show_strip_color_tag); drawmeta_contents(scene, seq, x1, y1, x2, y2, show_strip_color_tag);
} }
if ((sseq->flag & SEQ_SHOW_OVERLAY) && if ((sseq->flag & SEQ_SHOW_OVERLAY) &&
(sseq->timeline_overlay.flag & SEQ_TIMELINE_SHOW_THUMBNAILS) && (sseq->timeline_overlay.flag & SEQ_TIMELINE_SHOW_THUMBNAILS) &&
(ELEM(seq->type, SEQ_TYPE_MOVIE, SEQ_TYPE_IMAGE))) { (ELEM(seq->type, SEQ_TYPE_MOVIE, SEQ_TYPE_IMAGE))) {
draw_seq_strip_thumbnail(v2d, C, scene, seq, y1, y2, pixelx, pixely); draw_seq_strip_thumbnail(
v2d, C, scene, seq, y1, y_threshold ? text_margin_y : y2, pixelx, pixely);
becoAuthorUnsubmitted
Done
Inline Actions

These 0.05f are arbitrary constants i put there because I wanted to leave a partial view of the color of the underlying strip.

beco: These `0.05f` are arbitrary constants i put there because I wanted to leave a partial view of…
ISSUnsubmitted
Not Done
Inline Actions

I don't really like this change. It makes thumbnails smaller even when text is visible - requires even taller strips to see the thumbnails.

Perhaps there could be small offset when there is no text, and this offset does not need to be on both sides. But I don't think there is need for this offset really.

ISS: I don't really like this change. It makes thumbnails smaller even when text is visible…
} }
if ((sseq->flag & SEQ_SHOW_OVERLAY) && if ((sseq->flag & SEQ_SHOW_OVERLAY) &&
(sseq->timeline_overlay.flag & SEQ_TIMELINE_SHOW_FCURVES)) { (sseq->timeline_overlay.flag & SEQ_TIMELINE_SHOW_FCURVES)) {
draw_seq_fcurve_overlay(scene, v2d, seq, x1, y1, x2, y2, pixelx); draw_seq_fcurve_overlay(scene, v2d, seq, x1, y1, x2, y2, pixelx);
} }
/* Draw sound strip waveform. */ /* Draw sound strip waveform. */
▲ Show 20 Lines • Show All 828 Lines • ▼ Show 20 Lines if (ibuf) {
} }
} }
if (show_imbuf && (sseq->flag & SEQ_SHOW_OVERLAY)) { if (show_imbuf && (sseq->flag & SEQ_SHOW_OVERLAY)) {
sequencer_draw_borders_overlay(sseq, v2d, scene); sequencer_draw_borders_overlay(sseq, v2d, scene);
} }
if (!draw_backdrop && scene->ed != NULL) { if (!draw_backdrop && scene->ed != NULL) {
SeqCollection *collection = SEQ_query_rendered_strips(&scene->ed->seqbase, timeline_frame, 0); SeqCollection *collection = SEQ_query_rendered_strips(scene->ed->seqbasep, timeline_frame, 0);
Sequence *seq; Sequence *seq;
Sequence *active_seq = SEQ_select_active_get(scene); Sequence *active_seq = SEQ_select_active_get(scene);
SEQ_ITERATOR_FOREACH (seq, collection) { SEQ_ITERATOR_FOREACH (seq, collection) {
seq_draw_image_origin_and_outline(C, seq, seq == active_seq); seq_draw_image_origin_and_outline(C, seq, seq == active_seq);
} }
SEQ_collection_free(collection); SEQ_collection_free(collection);
} }
▲ Show 20 Lines • Show All 574 Lines • Show Last 20 Lines