Page MenuHome
Differential D13082 Diff 44449 source/blender/blenkernel/intern/subdiv_mesh.c

Changeset View

Standalone View

View Options

source/blender/blenkernel/intern/subdiv_mesh.c

Show First 20 Lines • Show All 1,077 Lines • ▼ Show 20 Lines
static void subdiv_mesh_vertex_of_loose_edge_interpolate(SubdivMeshContext *ctx, static void subdiv_mesh_vertex_of_loose_edge_interpolate(SubdivMeshContext *ctx,
const MEdge *coarse_edge, const MEdge *coarse_edge,
const float u, const float u,
const int subdiv_vertex_index) const int subdiv_vertex_index)
{ {
const Mesh *coarse_mesh = ctx->coarse_mesh; const Mesh *coarse_mesh = ctx->coarse_mesh;
Mesh *subdiv_mesh = ctx->subdiv_mesh; Mesh *subdiv_mesh = ctx->subdiv_mesh;
if (u == 0.0f) { /* This is never used for end-points (which are copied from the original). */
CustomData_copy_data(
&coarse_mesh->vdata, &subdiv_mesh->vdata, coarse_edge->v1, subdiv_vertex_index, 1);
}
else if (u == 1.0f) {
CustomData_copy_data(
&coarse_mesh->vdata, &subdiv_mesh->vdata, coarse_edge->v2, subdiv_vertex_index, 1);
}
else {
BLI_assert(u > 0.0f); BLI_assert(u > 0.0f);
BLI_assert(u < 1.0f); BLI_assert(u < 1.0f);
const float interpolation_weights[2] = {1.0f - u, u}; const float interpolation_weights[2] = {1.0f - u, u};
const int coarse_vertex_indices[2] = {coarse_edge->v1, coarse_edge->v2}; const int coarse_vertex_indices[2] = {coarse_edge->v1, coarse_edge->v2};
CustomData_interp(&coarse_mesh->vdata, CustomData_interp(&coarse_mesh->vdata,
&subdiv_mesh->vdata, &subdiv_mesh->vdata,
coarse_vertex_indices, coarse_vertex_indices,
interpolation_weights, interpolation_weights,
NULL, NULL,
2, 2,
subdiv_vertex_index); subdiv_vertex_index);
if (ctx->vert_origindex != NULL) { if (ctx->vert_origindex != NULL) {
ctx->vert_origindex[subdiv_vertex_index] = ORIGINDEX_NONE; ctx->vert_origindex[subdiv_vertex_index] = ORIGINDEX_NONE;
} }
} }
}
static void subdiv_mesh_vertex_of_loose_edge(const struct SubdivForeachContext *foreach_context, static void subdiv_mesh_vertex_of_loose_edge(const struct SubdivForeachContext *foreach_context,
void *UNUSED(tls), void *UNUSED(tls),
const int coarse_edge_index, const int coarse_edge_index,
const float u, const float u,
const int subdiv_vertex_index) const int subdiv_vertex_index)
{ {
SubdivMeshContext *ctx = foreach_context->user_data; SubdivMeshContext *ctx = foreach_context->user_data;
const Mesh *coarse_mesh = ctx->coarse_mesh; const Mesh *coarse_mesh = ctx->coarse_mesh;
const MEdge *coarse_edge = &coarse_mesh->medge[coarse_edge_index]; const MEdge *coarse_edge = &coarse_mesh->medge[coarse_edge_index];
Mesh *subdiv_mesh = ctx->subdiv_mesh; Mesh *subdiv_mesh = ctx->subdiv_mesh;
MVert *subdiv_mvert = subdiv_mesh->mvert; MVert *subdiv_mvert = subdiv_mesh->mvert;
const bool is_simple = ctx->subdiv->settings.is_simple; const bool is_simple = ctx->subdiv->settings.is_simple;
/* Find neighbors of the current loose edge. */ /* Find neighbors of the current loose edge. */
const MEdge *neighbors[2]; const MEdge *neighbors[2];
find_edge_neighbors(ctx, coarse_edge, neighbors); find_edge_neighbors(ctx, coarse_edge, neighbors);
/* Interpolate custom data. */ /* Interpolate custom data when not an end point.
* This data has already been initialized by #subdiv_mesh_vertex_loose. */
if (u != 0.0 && u != 1.0) {
subdiv_mesh_vertex_of_loose_edge_interpolate(ctx, coarse_edge, u, subdiv_vertex_index); subdiv_mesh_vertex_of_loose_edge_interpolate(ctx, coarse_edge, u, subdiv_vertex_index);
}
sergeyUnsubmitted
Done
Inline Actions

Initialized != assigned to what it is supposed to be based on the interpolation and whatnot. The comment also doesn't mention where exactly the assignment happened.

For the endpoint which connects loose edge to the manifold it is quite clear where the interpolation happens. But it is unclear to me where interpolation of endpoint of edge which is not adjacent to the manifold happens.

sergey: `Initialized` != `assigned to what it is supposed to be based on the interpolation and whatnot`.
/* Interpolate coordinate. */ /* Interpolate coordinate. */
MVert *subdiv_vertex = &subdiv_mvert[subdiv_vertex_index]; MVert *subdiv_vertex = &subdiv_mvert[subdiv_vertex_index];
if (is_simple) { if (is_simple) {
const MVert *coarse_mvert = coarse_mesh->mvert; const MVert *coarse_mvert = coarse_mesh->mvert;
const MVert *vert_1 = &coarse_mvert[coarse_edge->v1]; const MVert *vert_1 = &coarse_mvert[coarse_edge->v1];
const MVert *vert_2 = &coarse_mvert[coarse_edge->v2]; const MVert *vert_2 = &coarse_mvert[coarse_edge->v2];
interp_v3_v3v3(subdiv_vertex->co, vert_1->co, vert_2->co, u); interp_v3_v3v3(subdiv_vertex->co, vert_1->co, vert_2->co, u);
} }
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines