Page MenuHome
Differential D13142 Diff 44486 source/blender/blenkernel/intern/mesh_runtime.c

Changeset View

Standalone View

View Options

source/blender/blenkernel/intern/mesh_runtime.c

Show All 38 Lines
#include "BKE_mesh_runtime.h" #include "BKE_mesh_runtime.h"
#include "BKE_shrinkwrap.h" #include "BKE_shrinkwrap.h"
#include "BKE_subdiv_ccg.h" #include "BKE_subdiv_ccg.h"
/* -------------------------------------------------------------------- */ /* -------------------------------------------------------------------- */
/** \name Mesh Runtime Struct Utils /** \name Mesh Runtime Struct Utils
* \{ */ * \{ */
/** static void BKE_mesh_runtime_init_mutexes(Mesh *mesh)
mont29Unsubmitted
Done
Inline Actions

static functions do not take the module prefix (so just mesh_runtime_init_mutexes)

mont29: static functions do not take the module prefix (so just `mesh_runtime_init_mutexes`)
* Default values defined at read time.
*/
void BKE_mesh_runtime_reset(Mesh *mesh)
{ {
memset(&mesh->runtime, 0, sizeof(mesh->runtime));
mesh->runtime.eval_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime eval_mutex"); mesh->runtime.eval_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime eval_mutex");
BLI_mutex_init(mesh->runtime.eval_mutex); BLI_mutex_init(mesh->runtime.eval_mutex);
mesh->runtime.render_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime render_mutex"); mesh->runtime.render_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime render_mutex");
BLI_mutex_init(mesh->runtime.render_mutex); BLI_mutex_init(mesh->runtime.render_mutex);
} }
/* Clear all pointers which we don't want to be shared on copying the datablock. static void BKE_mesh_runtime_reset_mutexes(Mesh *mesh)
* However, keep all the flags which defines what the mesh is (for example, that
* it's deformed only, or that its custom data layers are out of date.) */
void BKE_mesh_runtime_reset_on_copy(Mesh *mesh, const int UNUSED(flag))
{ {
Mesh_Runtime *runtime = &mesh->runtime; memset(&mesh->runtime, 0, sizeof(mesh->runtime));
mont29Unsubmitted
Done
Inline Actions

This has nothing to do here? You create a set of functions dedicated to mutexes, but then wipe out the entire runtime struct in them?

mont29: This has nothing to do here? You create a set of functions dedicated to mutexes, but then wipe…
BKE_mesh_runtime_init_mutexes(mesh);
mont29Unsubmitted
Done
Inline Actions

static functions do not take the module prefix (so just mesh_runtime_free_mutexes)

mont29: static functions do not take the module prefix (so just `mesh_runtime_free_mutexes`)
runtime->mesh_eval = NULL;
runtime->edit_data = NULL;
runtime->batch_cache = NULL;
runtime->subdiv_ccg = NULL;
memset(&runtime->looptris, 0, sizeof(runtime->looptris));
runtime->bvh_cache = NULL;
runtime->shrinkwrap_data = NULL;
mesh->runtime.eval_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime eval_mutex");
BLI_mutex_init(mesh->runtime.eval_mutex);
mesh->runtime.render_mutex = MEM_mallocN(sizeof(ThreadMutex), "mesh runtime render_mutex");
BLI_mutex_init(mesh->runtime.render_mutex);
} }
void BKE_mesh_runtime_clear_cache(Mesh *mesh) void BKE_mesh_runtime_free_mutexes(struct Mesh *mesh)
mont29Unsubmitted
Not Done
Inline Actions

Would be nice to add doc to this one too?

mont29: Would be nice to add doc to this one too?
{ {
if (mesh->runtime.eval_mutex != NULL) { if (mesh->runtime.eval_mutex != NULL) {
BLI_mutex_end(mesh->runtime.eval_mutex); BLI_mutex_end(mesh->runtime.eval_mutex);
MEM_freeN(mesh->runtime.eval_mutex); MEM_freeN(mesh->runtime.eval_mutex);
mesh->runtime.eval_mutex = NULL; mesh->runtime.eval_mutex = NULL;
} }
if (mesh->runtime.render_mutex != NULL) { if (mesh->runtime.render_mutex != NULL) {
BLI_mutex_end(mesh->runtime.render_mutex); BLI_mutex_end(mesh->runtime.render_mutex);
MEM_freeN(mesh->runtime.render_mutex); MEM_freeN(mesh->runtime.render_mutex);
mesh->runtime.render_mutex = NULL; mesh->runtime.render_mutex = NULL;
} }
if (mesh->runtime.mesh_eval != NULL) { if (mesh->runtime.mesh_eval != NULL) {
mesh->runtime.mesh_eval->edit_mesh = NULL; mesh->runtime.mesh_eval->edit_mesh = NULL;
BKE_id_free(NULL, mesh->runtime.mesh_eval); BKE_id_free(NULL, mesh->runtime.mesh_eval);
mesh->runtime.mesh_eval = NULL; mesh->runtime.mesh_eval = NULL;
} }
mont29Unsubmitted
Done
Inline Actions

This also has nothing to do in a mutexes specific function.

mont29: This also has nothing to do in a `mutexes` specific function.
}
/**
* Default values defined at read time.
*/
void BKE_mesh_runtime_reset(Mesh *mesh)
{
BKE_mesh_runtime_reset_mutexes(mesh);
}
/* Clear all pointers which we don't want to be shared on copying the datablock.
* However, keep all the flags which defines what the mesh is (for example, that
* it's deformed only, or that its custom data layers are out of date.) */
void BKE_mesh_runtime_reset_on_copy(Mesh *mesh, const int UNUSED(flag))
{
Mesh_Runtime *runtime = &mesh->runtime;
runtime->mesh_eval = NULL;
runtime->edit_data = NULL;
runtime->batch_cache = NULL;
runtime->subdiv_ccg = NULL;
memset(&runtime->looptris, 0, sizeof(runtime->looptris));
runtime->bvh_cache = NULL;
runtime->shrinkwrap_data = NULL;
BKE_mesh_runtime_reset_mutexes(mesh);
mont29Unsubmitted
Done
Inline Actions

Calling this here effectively wipes out the entire runtime struct, which is exactly what we do not want to do here...

mont29: Calling this here effectively wipes out the entire `runtime` struct, which is exactly what we…
}
void BKE_mesh_runtime_clear_cache(Mesh *mesh)
{
BKE_mesh_runtime_clear_geometry(mesh); BKE_mesh_runtime_clear_geometry(mesh);
BKE_mesh_batch_cache_free(mesh); BKE_mesh_batch_cache_free(mesh);
BKE_mesh_runtime_clear_edit_data(mesh); BKE_mesh_runtime_clear_edit_data(mesh);
} }
/* This is a ported copy of DM_ensure_looptri_data(dm) */ /* This is a ported copy of DM_ensure_looptri_data(dm) */
/** /**
* Ensure the array is large enough * Ensure the array is large enough
▲ Show 20 Lines • Show All 358 Lines • Show Last 20 Lines