Changeset View
Standalone View
source/blender/blenlib/BLI_fileops.hh
- This file was added.
| /* | |||||
| * This program is free software; you can redistribute it and/or | |||||
| * modify it under the terms of the GNU General Public License | |||||
| * as published by the Free Software Foundation; either version 2 | |||||
| * of the License, or (at your option) any later version. | |||||
| * | |||||
| * This program is distributed in the hope that it will be useful, | |||||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | |||||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |||||
| * GNU General Public License for more details. | |||||
| * | |||||
| * You should have received a copy of the GNU General Public License | |||||
| * along with this program; if not, write to the Free Software Foundation, | |||||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||||
| */ | |||||
| /** \file | |||||
JacquesLucke: Outdated license header. | |||||
| * \ingroup bli | |||||
| * \brief File and directory operations. | |||||
| */ | |||||
| #pragma once | |||||
| #ifndef __cplusplus | |||||
| # error This is a C++ header | |||||
| #endif | |||||
| #include "BLI_fileops.h" | |||||
| #include "BLI_string_ref.hh" | |||||
| #include <fstream> | |||||
| #include <string> | |||||
| namespace blender { | |||||
| /** | |||||
| * std::fstream subclass that handles UTF-16 encoding on Windows. | |||||
| * | |||||
| * For documentation, see https://en.cppreference.com/w/cpp/io/basic_fstream | |||||
| */ | |||||
| class fstream : public std::fstream { | |||||
| public: | |||||
| fstream() = default; | |||||
| explicit fstream(const char *filepath, | |||||
| std::ios_base::openmode mode = ios_base::in | ios_base::out); | |||||
| explicit fstream(const std::string &filepath, | |||||
| std::ios_base::openmode mode = ios_base::in | ios_base::out); | |||||
Done Inline ActionsIs this filename or filepath, or are these synonym in this context? JacquesLucke: Is this `filename` or `filepath`, or are these synonym in this context? | |||||
Done Inline ActionsSynonym, these declarations were copied verbatim from https://en.cppreference.com/w/cpp/io/basic_fstream sybren: Synonym, these declarations were copied verbatim from https://en.cppreference. | |||||
Done Inline ActionsI like filepath more though, so I'll update the code for that. sybren: I like `filepath` more though, so I'll update the code for that. | |||||
| void open(StringRefNull filepath, ios_base::openmode mode = ios_base::in | ios_base::out); | |||||
| }; | |||||
Done Inline ActionsWhy do you delete this explicitly? Looks like std::fstream deletes the copy constructor already. JacquesLucke: Why do you delete this explicitly? Looks like `std::fstream` deletes the copy constructor… | |||||
| } // namespace blender | |||||
Done Inline ActionsBoth open functions could be merged by using StringRef. JacquesLucke: Both `open` functions could be merged by using `StringRef`. | |||||
Done Inline ActionsThat could be done, but would remove the symmetry with what's declared on https://en.cppreference.com/w/cpp/io/basic_fstream Is there a guarantee that the compiler will choose our StringRef override over the (then not overridden) const char * and const std::string & functions of std::fstream? sybren: That could be done, but would remove the symmetry with what's declared on https://en. | |||||
Done Inline ActionsNever mind, C++ is being C++. I added an override keyword and the compiler puked at me. At least the VS2019 implementation of STL uses different arguments than documented at https://en.cppreference.com/w/cpp/io/basic_fstream/open, so I'll just embrace the "fluid standard" and have one StringRef implementation. sybren: Never mind, C++ is being C++. I added an `override` keyword and the compiler puked at me. At… | |||||
Outdated license header.