Differential D1370 Diff 4466 source/gameengine/Rasterizer/RAS_2DFilterManager.cpp

Changeset View

Standalone View

Context not available.
	for (i=0; i<objProperties; i++)	for (i=0; i<objProperties; i++)
	{	{
	uniformLoc = glGetUniformLocationARB(m_filters[passindex], m_properties[passindex][i]);	uniformLoc = glGetUniformLocationARB(m_filters[passindex], m_properties[passindex][i]);
	if (uniformLoc != -1)
	{	if (uniformLoc == -1)
	float value = ((CValue*)m_gameObjects[passindex])->GetPropertyNumber(m_properties[passindex][i], 0.0);	continue;
	glUniform1fARB(uniformLoc,value);
		CValue property = ((CValue)m_gameObjects[passindex])->GetProperty(m_properties[passindex][i]);

		if (!property)
		continue;

		int type = property->GetValueType();
		moguriUnsubmitted Not Done Inline Actions This is a minor nitpick, but I'd prefer to not declare variables in the middle of a scope. I also don't really see the point of storing the result of property->GetValueType() when we could do switch (property->GetValueType()) { And it still looks fine. moguri: This is a minor nitpick, but I'd prefer to not declare variables in the middle of a scope. I…

		switch (type) {
		case VALUE_INT_TYPE:
		glUniform1iARB(uniformLoc, property->GetNumber());
		break;
		case VALUE_FLOAT_TYPE:
		glUniform1fARB(uniformLoc, property->GetNumber());
		break;
		default:
		break;
	}	}
	}	}
	}	}
Context not available.