Changeset View
Changeset View
Standalone View
Standalone View
source/blender/makesdna/DNA_curve_types.h
| Show First 20 Lines • Show All 280 Lines • ▼ Show 20 Lines | typedef struct Curve { | ||||
| float bevfac1, bevfac2; | float bevfac1, bevfac2; | ||||
| char bevfac1_mapping, bevfac2_mapping; | char bevfac1_mapping, bevfac2_mapping; | ||||
| char _pad2[6]; | char _pad2[6]; | ||||
| float fsize_realtime; | float fsize_realtime; | ||||
| /** | /** | ||||
| * A pointer to curve data from evaluation. Owned by the object's #geometry_set_eval, either as a | * A pointer to curve data from evaluation. Owned by the object's #geometry_set_eval, either as a | ||||
| * geometry instance or the data of the evaluated #CurveComponent. The curve may also contain | * geometry instance or the data of the evaluated #CurveComponent. For evaluated curves this is | ||||
| * data in the #nurb list, but for evaluated curves this is the proper place to retrieve data, | * the proper place to retrieve data, since it contains the result of geometry nodes evaluation, | ||||
| * since it also contains the result of geometry nodes evaluation, and isn't just a copy of the | * and isn't just a copy of the original object data. | ||||
| * original object data. | |||||
| */ | */ | ||||
| const struct Curves *curve_eval; | const struct Curves *curve_eval; | ||||
sergey: The description mentions removal of `curve_eval`, but it is still here?
It also feels that it… | |||||
Done Inline ActionsAh, totally right, sorry. That was left over from an earlier attempted fix. I updated the description. HooglyBoogly: Ah, totally right, sorry. That was left over from an earlier attempted fix. I updated the… | |||||
| void *batch_cache; | void *batch_cache; | ||||
| } Curve; | } Curve; | ||||
| #define CURVE_VFONT_ANY(cu) ((cu)->vfont), ((cu)->vfontb), ((cu)->vfonti), ((cu)->vfontbi) | #define CURVE_VFONT_ANY(cu) ((cu)->vfont), ((cu)->vfontb), ((cu)->vfonti), ((cu)->vfontbi) | ||||
Done Inline ActionsWhat about edit_data_shared to avoid double negations (if not edit_data_not_owned)? sergey: What about `edit_data_shared` to avoid double negations (if not edit_data_not_owned)? | |||||
Done Inline ActionsGuess the main reason for this name is that it has minimal impact on existing code? JacquesLucke: Guess the main reason for this name is that it has minimal impact on existing code? | |||||
| /* **************** CURVE ********************* */ | /* **************** CURVE ********************* */ | ||||
| /** #Curve.texflag */ | /** #Curve.texflag */ | ||||
| enum { | enum { | ||||
| CU_AUTOSPACE = 1, | CU_AUTOSPACE = 1, | ||||
| CU_AUTOSPACE_EVALUATED = 2, | CU_AUTOSPACE_EVALUATED = 2, | ||||
| }; | }; | ||||
| ▲ Show 20 Lines • Show All 291 Lines • Show Last 20 Lines | |||||
The description mentions removal of curve_eval, but it is still here?
It also feels that it should be in the runtime.