Changeset View
Changeset View
Standalone View
Standalone View
source/blender/editors/mesh/editface.cc
| Show First 20 Lines • Show All 545 Lines • ▼ Show 20 Lines | if ((mv->flag & ME_HIDE) == 0) { | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| if (flush_flags) { | if (flush_flags) { | ||||
| paintvert_flush_flags(ob); | paintvert_flush_flags(ob); | ||||
| } | } | ||||
| } | } | ||||
| void paintvert_hide(bContext *C, Object *ob, const bool unselected) | |||||
| { | |||||
| Mesh *const me = BKE_mesh_from_object(ob); | |||||
| if (me == NULL || me->totvert == 0) { | |||||
| return; | |||||
| } | |||||
| for (int i = 0; i < me->totvert; i++) { | |||||
| MVert *const mvert = &me->mvert[i]; | |||||
| if ((mvert->flag & ME_HIDE) == 0) { | |||||
HooglyBoogly: Just passing through here (I have some refactors in this file to the way hiding flags are… | |||||
| if (((mvert->flag & SELECT) == 0) == unselected) { | |||||
| mvert->flag |= ME_HIDE; | |||||
| } | |||||
| } | |||||
| if (mvert->flag & ME_HIDE) { | |||||
| mvert->flag &= ~SELECT; | |||||
| } | |||||
| } | |||||
| BKE_mesh_flush_hidden_from_verts(me); | |||||
| paintvert_flush_flags(ob); | |||||
| paintvert_tag_select_update(C, ob); | |||||
| } | |||||
| void paintvert_reveal(bContext *C, Object *ob, const bool select) | |||||
| { | |||||
| Mesh *const me = BKE_mesh_from_object(ob); | |||||
| if (me == NULL || me->totvert == 0) { | |||||
| return; | |||||
| } | |||||
| for (int i = 0; i < me->totvert; i++) { | |||||
| MVert *const mvert = &me->mvert[i]; | |||||
| if (mvert->flag & ME_HIDE) { | |||||
| SET_FLAG_FROM_TEST(mvert->flag, select, SELECT); | |||||
| mvert->flag &= ~ME_HIDE; | |||||
| } | |||||
| } | |||||
| BKE_mesh_flush_hidden_from_verts(me); | |||||
| paintvert_flush_flags(ob); | |||||
| paintvert_tag_select_update(C, ob); | |||||
| } | |||||
Just passing through here (I have some refactors in this file to the way hiding flags are stored, which is why I'm interested). Could I suggest a simpler/more standard for loop syntax?
for (int i = 0; i < me->totvert; i++) { MVert &mvert = me->mvert[i]; ... }Or if you wanted you could go a bit further:
for (const int i : IndexRange(me->totvert)) {This makes the code easier to read, and makes my job easier when merging master into my refactor after this is committed ;)