Changeset View
Changeset View
Standalone View
Standalone View
source/blender/modifiers/intern/MOD_array.c
| Show First 20 Lines • Show All 502 Lines • ▼ Show 20 Lines | if (ELEM(amd->fit_type, MOD_ARR_FITLENGTH, MOD_ARR_FITCURVE)) { | ||||
| } | } | ||||
| else { | else { | ||||
| /* if the offset has no translation, just make one copy */ | /* if the offset has no translation, just make one copy */ | ||||
| count = 1; | count = 1; | ||||
| offset_is_too_small = true; | offset_is_too_small = true; | ||||
| } | } | ||||
| if (offset_is_too_small) { | if (offset_is_too_small) { | ||||
| BKE_modifier_set_error( | BKE_modifier_set_error( | ||||
| ctx->object, | ctx->object, | ||||
| &amd->modifier, | &amd->modifier, | ||||
| "The offset is too small, we cannot generate the amount of geometry it would require"); | "The offset is too small, we cannot generate the amount of geometry it would require"); | ||||
mont29: This should not be needed, `BKE_modifier_set_error` should be handled automatically by the POT… | |||||
Done Inline ActionsFair enough, I’m not skilled enough to investigate further! pioverfour: Fair enough, I’m not skilled enough to investigate further! | |||||
| } | } | ||||
| } | } | ||||
| /* Ensure we keep things to a reasonable level, in terms of rough total amount of generated | /* Ensure we keep things to a reasonable level, in terms of rough total amount of generated | ||||
| * vertices. | * vertices. | ||||
| */ | */ | ||||
| else if (((size_t)count * (size_t)chunk_nverts + (size_t)start_cap_nverts + | else if (((size_t)count * (size_t)chunk_nverts + (size_t)start_cap_nverts + | ||||
| (size_t)end_cap_nverts) > max_vertices_num) { | (size_t)end_cap_nverts) > max_vertices_num) { | ||||
| count = 1; | count = 1; | ||||
| ▲ Show 20 Lines • Show All 474 Lines • ▼ Show 20 Lines | modifier_subpanel_register( | ||||
| region_type, "object_offset", "", object_offset_header_draw, object_offset_draw, panel_type); | region_type, "object_offset", "", object_offset_header_draw, object_offset_draw, panel_type); | ||||
| modifier_subpanel_register( | modifier_subpanel_register( | ||||
| region_type, "merge", "", symmetry_panel_header_draw, symmetry_panel_draw, panel_type); | region_type, "merge", "", symmetry_panel_header_draw, symmetry_panel_draw, panel_type); | ||||
| modifier_subpanel_register(region_type, "uv", "UVs", NULL, uv_panel_draw, panel_type); | modifier_subpanel_register(region_type, "uv", "UVs", NULL, uv_panel_draw, panel_type); | ||||
| modifier_subpanel_register(region_type, "caps", "Caps", NULL, caps_panel_draw, panel_type); | modifier_subpanel_register(region_type, "caps", "Caps", NULL, caps_panel_draw, panel_type); | ||||
| } | } | ||||
| ModifierTypeInfo modifierType_Array = { | ModifierTypeInfo modifierType_Array = { | ||||
| /* name */ "Array", | /* name */ N_("Array"), | ||||
| /* structName */ "ArrayModifierData", | /* structName */ "ArrayModifierData", | ||||
| /* structSize */ sizeof(ArrayModifierData), | /* structSize */ sizeof(ArrayModifierData), | ||||
| /* srna */ &RNA_ArrayModifier, | /* srna */ &RNA_ArrayModifier, | ||||
| /* type */ eModifierTypeType_Constructive, | /* type */ eModifierTypeType_Constructive, | ||||
| /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsMapping | | /* flags */ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_SupportsMapping | | ||||
| eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode | | eModifierTypeFlag_SupportsEditmode | eModifierTypeFlag_EnableInEditmode | | ||||
| eModifierTypeFlag_AcceptsCVs, | eModifierTypeFlag_AcceptsCVs, | ||||
| /* icon */ ICON_MOD_ARRAY, | /* icon */ ICON_MOD_ARRAY, | ||||
| Show All 24 Lines | |||||
This should not be needed, BKE_modifier_set_error should be handled automatically by the POT generation tool. Not sure why it fails off hands, but it needs to be properly fixed.